fix(proxy): register WebSocket passthrough for OpenAI prefixes (CI mirror of #36151) - #37120
Closed
mateo-berri wants to merge 10 commits into
Closed
fix(proxy): register WebSocket passthrough for OpenAI prefixes (CI mirror of #36151)#37120mateo-berri wants to merge 10 commits into
mateo-berri wants to merge 10 commits into
Conversation
create_websocket_passthrough_route existed but /openai and /openai_passthrough only registered HTTP methods, so WS upgrades were rejected at routing. Add catch-all websocket routes mirroring the HTTP passthrough target construction. Fixes #36088
Forward realtime model query string, keep OPENAI_API_KEY (forward_headers=False), satisfy ruff strict gates, sync dashboard OpenAPI types, and cover the behavior in tests.
- decode upstream first frame as utf-8 instead of ascii - reject model-restricted keys at connect to match HTTP model enforcement - log the actual request path for /openai_passthrough traffic
|
|
…itellm_pr36151_ws_passthrough # Conflicts: # litellm/proxy/pass_through_endpoints/pass_through_endpoints.py # tests/test_litellm/proxy/pass_through_endpoints/test_pass_through_endpoints.py
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Contributor
Author
|
Closing: CI mirror no longer needed, PR 36151 runs its own checks after the conflict resolution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI vehicle for PR #36151, whose fork pushes produce no GitHub Actions check suites (close/reopen and new pushes were tried). Same head sha 862f33b, so the check runs attach to that commit and satisfy the required contexts on the original PR
Do not merge or review. This draft gets closed once #36151 lands