test(e2e/ui): assert the log drawer chevrons by their lucide classes - #37069
Merged
yuneng-berri merged 1 commit intoAug 16, 2026
Merged
Conversation
The log details drawer moved off Ant Design in 03d2b16, so its section header renders lucide ChevronUp/ChevronDown rather than antd's UpOutlined and DownOutlined. The collapse test still waited on .anticon-up and .anticon-down, which no longer exist anywhere under view_logs, so it failed on every run and burned all three attempts identically. Point the three assertions at .lucide-chevron-up and .lucide-chevron-down, matching how the dashboard's other suites address lucide icons.
Contributor
Greptile SummaryThis PR repairs the log drawer collapse/expand e2e test by aligning its chevron selectors with the currently rendered Lucide icons.
Confidence Score: 5/5The PR appears safe to merge because the updated selectors match the drawer's rendered chevrons and preserve the existing collapse, expansion, and content checks. The change is confined to e2e selectors, and repository context confirms that the Input header renders the corresponding Lucide class for each state while the surrounding behavioral coverage remains intact.
|
| Filename | Overview |
|---|---|
| tests/e2e/ui/tests/logs/logs.spec.ts | Updates three stale icon selectors to match the uniquely rendered Lucide chevrons without weakening the test's behavioral assertions. |
Reviews (1): Last reviewed commit: "test(e2e/ui): assert the log drawer chev..." | Re-trigger Greptile
tin-berri
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
How it solves it:
User Flow
This PR changes only an e2e test, so no end user's flow changes. The flow the test walks is unaffected in both directions:
Before: a proxy admin inspecting a request can already collapse and expand the Input card
After: identical, step for step. The drawer, the header, the chevron and the collapse behavior are all unchanged
Relevant issues
Linear ticket
Pre-Submission checklist
@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
Run against a live proxy on localhost:4000 with the seeded e2e stack (
PROXY_PORT=4000 E2E_KEEP_ALIVE=1 ./tests/e2e/ui/run_e2e.sh), the same environment CircleCI'se2e_ui_testingbuilds. Both sides ran withCI=true, so each failure burns all three attempts exactly as CI does.Before (ae8afec)
npx playwright test --config playwright.config.ts -g "the Input card collapses and expands"e2e_ui_testingat this same commit, where it is the only failure:1 failed, 2 skipped, 98 passedAfter (de2b220)
npx playwright test --config playwright.config.ts -g "the Input card collapses and expands"npx playwright test --config playwright.config.tslogs.spec.tswas the sole failure, and it fails here identically with and without this changeType
🐛 Bug Fix
✅ Test
Caveats (if any)
.anticonselector remainsQA runbook
PROXY_PORT=4000 E2E_KEEP_ALIVE=1 ./tests/e2e/ui/run_e2e.shcurl -X POST http://localhost:4000/v1/chat/completions -H "Authorization: Bearer sk-1234" -d '{"model":"fake-openai-gpt-4","messages":[{"role":"user","content":"qa-collapse-probe"}]}'qa-collapse-probeon screenFinal Attestation