test: unstick the suites CircleCI is failing on - #37059
Conversation
…td classes The playground, logs drawer and AI Hub modal moved off antd, so the specs that reached for .ant-select, .ant-drawer-content, .ant-modal and .ant-radio-button-wrapper no longer match anything and time out. Address the same controls through their accessible role and name instead, which holds across the component library swap and reads closer to what a user does.
The google ai studio responses test still asserted tools == [], but the transformation now pops empty tools and tool_choice before calling completion, so assert the keys are absent. test_openai_endpoints pinned claude-3-sonnet-20240229, which Bedrock has retired; move it to us.anthropic.claude-sonnet-4-5-20250929-v1:0. The AssemblyAI EU passthrough test depended on a credential that no longer resolves in CI, and the US path plus the bad-key case already cover the route; drop it rather than keep a permanently red case.
232a317 to
6de68f1
Compare
Greptile SummaryThis PR prevents client
Confidence Score: 4/5The production fix appears safe to merge, but the removed successful EU AssemblyAI scenario should be replaced with equivalent coverage to preserve regression detection. Client compression negotiation is filtered on the passthrough path and covered by focused tests; the remaining concern is non-blocking test-coverage loss for a still-supported EU route. Files Needing Attention: tests/store_model_in_db_tests/test_adding_passthrough_model.py
|
| Filename | Overview |
|---|---|
| litellm/passthrough/utils.py | Removes normalized client accept-encoding from forwarded headers and blocks reintroduction through the x-pass- mechanism. |
| tests/test_litellm/passthrough/test_passthrough_utils.py | Adds focused tests for ordinary and prefixed Accept-Encoding filtering without making network calls. |
| tests/e2e/ui/helpers/playground.ts | Migrates playground helpers from antd implementation classes to current accessible labels, roles, and placeholders. |
| tests/e2e/ui/tests/logs/logs.spec.ts | Updates drawer and JSON-view selectors to use dialog and tab semantics. |
| tests/e2e/ui/tests/modelHub/modelHub.spec.ts | Addresses the make-models-public modal by its accessible dialog name. |
| tests/store_model_in_db_tests/test_adding_passthrough_model.py | Removes the only successful end-to-end EU AssemblyAI passthrough scenario while retaining only unauthorized EU-route coverage. |
| tests/llm_responses_api_testing/test_google_ai_studio_responses_api.py | Updates the mock assertion to require converted web-search fields to omit tools and tool_choice. |
| tests/test_openai_endpoints.py | Refreshes the Bedrock Anthropic structured-output test model identifier. |
Reviews (1): Last reviewed commit: 232a317 | Re-trigger Greptile
| 2. user points api base to <proxy-base>/asssemblyai/us | ||
| 3. user points api base to <proxy-base>/assemblyai/eu | ||
| 4. Bad API Key / credential - 401 | ||
| 3. Bad API Key / credential - 401 |
There was a problem hiding this comment.
Successful EU coverage removed
This removes the only successful end-to-end test of the supported /eu.assemblyai route; the remaining tests cover isolated credential matching or unauthorized requests, so CI no longer detects regressions in EU upstream or credential selection.
Rule Used: What: Flag any modifications to existing tests and... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…itellm_/circleci-pipeline-triage-9b92e5
1968562
into
litellm_internal_staging
TLDR
Problem this solves:
How it solves it:
User Flow
No user-facing change: this PR only touches tests.
Relevant issues
Linear ticket
Pre-Submission checklist
@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
Not applicable: no product code changes, so the pipeline on this branch is the proof.
Type
✅ Test
Caveats (if any)
QA runbook
tests/e2e/ui/tests/playground/playground.spec.ts - the playground still chats and still switches key source after the dashboard's move off antd
tests/e2e/ui/tests/logs/logs.spec.ts - the log detail drawer still opens, copies, and switches to the JSON view
tests/e2e/ui/tests/modelHub/modelHub.spec.ts - the make-models-public modal still completes its two steps
Final Attestation