feat(ui): standardize the Teams page header - #36897
Merged
yuneng-berri merged 2 commits intoAug 20, 2026
Merged
Conversation
Contributor
Greptile SummaryThe PR introduces a standardized page-header contract and adopts it on Teams while preserving existing layouts through a legacy component.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/src/components/shared/PageHeader.tsx | Defines the standardized header identity and control-row composition, including embedded tab-shell support. |
| ui/litellm-dashboard/src/components/Teams.tsx | Adopts the standardized header while preserving team-creation permission gating, modal behavior, tabs, and detail-view spacing. |
| ui/litellm-dashboard/src/components/shared/LegacyPageHeader.tsx | Preserves the former header contract and presentation for pages outside the pilot migration. |
| ui/litellm-dashboard/src/components/Teams.test.tsx | Updates coverage for the Teams control-row placement, role gating, tab styling, and detail-view inset. |
Reviews (3): Last reviewed commit: "feat(ui): standardize the Teams page hea..." | Re-trigger Greptile
Collaborator
Author
Collaborator
Author
|
@veria-ai review |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
yuneng-berri
force-pushed
the
litellm_standard_page_header
branch
from
August 14, 2026 07:43
370ee75 to
28c1e43
Compare
Collaborator
Author
Collaborator
Author
|
@veria-ai review |
yuneng-berri
enabled auto-merge
August 14, 2026 16:25
…ader
Teams.tsx and Teams.test.tsx both conflicted with staging's antd -> shadcn
migration of the team create form.
Teams.tsx: took staging's rewritten import block and dropped `theme` from the
antd import, since this branch replaced `<Content style={{ padding: token... }}>`
with the Tailwind inset. Dropped both `const { Text } = Typography` (staging
removed its last use) and `const { token } = theme.useToken()` (this branch
removed its last use).
Teams.test.tsx: took this branch's PageHeader-shaped assertions over staging's
older tab-bar lookup, and restored the `within` import that staging had dropped.
Removed the `toHaveClass` snapshot of the antd tab-bar Tailwind classes and the
`.closest(".ant-tabs")` lookup: staging added local/no-antd-class-selectors as a
zero-violation error rule, and those assertions are inert in jsdom anyway. Every
behavioural assertion in that test is unchanged.
yucheng-berri
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
How it solves it:
User Flow
Before: a proxy admin opening the Teams page sees a one-off header that does not match the proposed dashboard pattern
After: the same proxy admin sees the standard page identity and control-row pattern without losing any Team behavior
Relevant issues
Linear ticket
Pre-Submission checklist
@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
Before/after captures are retained outside the repository and must be attached through GitHub's upload interface.
Live verification:
Type
New Feature
Caveats (if any)
Final Attestation