ci: retry transient network fetch failures in lint workflow - #36563
Merged
Conversation
Contributor
Greptile SummaryThis PR makes the lint workflow more resilient to transient network failures by adding three-attempt retries with 15- and 30-second backoff.
Confidence Score: 5/5The PR appears safe to merge because exhausted retries still fail their steps and successful retries preserve the existing fetch and lint behavior. The retry helper performs at most three attempts, returns the final command’s failure status when all attempts fail, and leaves the existing merge-base and secret-scan sequencing intact.
|
| Filename | Overview |
|---|---|
| .github/workflows/test-linting.yml | Adds bounded retries around three existing network-fetch paths while preserving final failure propagation and downstream validation. |
Reviews (1): Last reviewed commit: "ci: retry transient network fetch failur..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
yucheng-berri
approved these changes
Aug 11, 2026
mateo-berri
enabled auto-merge
August 11, 2026 19:19
tin-berri
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
How it solves it:
User Flow
Before: one runner network blip fails the required lint check before any lint runs, and the PR stays blocked until someone re-runs the job by hand
After: the same blip is absorbed inside the job and the check goes green in one run
Relevant issues
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
Reproduction, captured at d608948 on PR #36543: https://github.com/BerriAI/litellm/actions/runs/31518654317/job/93869992555 is the real transient failure that motivated this. The required lint job died 12 seconds in, on its first network step
Retry semantics, captured at e9156af with the exact helper line from the workflow: a command that fails once then succeeds is absorbed, and a command that always fails still fails the step after three attempts
This PR's own required lint check ran the retry-wrapped workflow at e9156af and passed in one run: https://github.com/BerriAI/litellm/actions/runs/31523584763. The happy path is unchanged with zero added latency, since the retries only engage after a failure
Type
🚄 Infrastructure
Caveats (if any)
Final Attestation