test: repair stale CircleCI contracts - #36293
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Greptile SummaryThe PR repairs stale CI expectations while keeping production behavior unchanged except for relocating the auto-router benchmark SQL constant.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking request to retain end-to-end TeamInfo coverage for newly added metadata. Production behavior remains equivalent, but deleting the TeamInfo add-pair test leaves the form-to-update-payload integration boundary without direct regression coverage. Files Needing Attention: ui/litellm-dashboard/src/components/team/TeamInfo.test.tsx
|
| Filename | Overview |
|---|---|
| litellm/proxy/db/autorouter_session_rollup.py | Receives the unchanged parameterized auto-router benchmark SQL constant without introducing an import cycle or optional runtime dependency. |
| litellm/proxy/management_endpoints/auto_router_endpoints.py | Imports and executes the relocated SQL constant with the existing parameters and response parsing. |
| tests/agent_tests/test_a2a_agent.py | Updates the A2A mock method signature to accept the current keyword-only context argument. |
| tests/litellm_utils_tests/test_proxy_budget_reset.py | Makes successful budget-reset fixtures attribute-compatible with the production batch-write path. |
| tests/llm_responses_api_testing/base_responses_api.py | Narrows retrieval comparison to stable aggregated text for the text-only request exercised by this test. |
| tests/proxy_behavior/spend/test_autorouter_session_rollup.py | Updates real-Postgres behavior tests to import benchmark SQL from its new database-module location. |
| ui/litellm-dashboard/src/components/team/TeamInfo.test.tsx | Removes unique integration coverage for newly added metadata reaching the team update payload. |
| ui/litellm-dashboard/src/lib/http/schema.d.ts | Reorders an equivalent generated string-literal union without changing its accepted values. |
Reviews (1): Last reviewed commit: "test: repair stale CircleCI contracts" | Re-trigger Greptile
| @@ -964,27 +964,6 @@ describe("TeamInfoView", () => { | |||
| expect(updateArg.model_tpm_limit).toEqual({ "gpt-4": 100 }); | |||
There was a problem hiding this comment.
Preserve added-metadata integration coverage
Deleting this test removes the only TeamInfo-level check that a newly added metadata row passes through form conversion into teamUpdateCall. The focused component test stops at raw form submission, so a regression that drops new metadata from the update payload would pass the dashboard test suite.
Rule Used: What: Flag any modifications to existing tests and... (source)
Knowledge Base Used: Admin dashboard (ui/litellm-dashboard)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
TLDR
Problem this solves:
How it solves it:
User Flow
Before: a maintainer runs internal staging CI and sees product-looking failures from outdated test assumptions
After: the same workflow checks current contracts and isolates provider-only failures
Relevant issues
CircleCI pipeline 88641
Linear ticket
Pre-Submission checklist
Screenshots / Proof of Fix
Not applicable for test-contract repairs
Validation:
make checkpassesType
Test
Changes
make checkOut of scope:
Final Attestation