Repository navigation
fix(streaming): keep n>1 choices separate in stream_chunk_builder #36208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
vineethsaivs
wants to merge
9
commits into
BerriAI:main
from
vineethsaivs:fix-stream-chunk-builder-multiple-choices
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
049f040
fix(streaming): keep n>1 choices separate in stream_chunk_builder
vineethsaivs b33a1eb
chore(streaming): give the per-index helpers real types
vineethsaivs 6679e9c
chore(streaming): use read-only collection types in the per-index hel…
vineethsaivs 8473655
chore(streaming): give the nine collection constructions their reasons
vineethsaivs e77568d
fix(streaming): narrow the built choices with isinstance instead of cast
vineethsaivs edfac7e
fix(streaming): annotate the narrowing helper with object rather than…
vineethsaivs 4771bba
fix(streaming): drop the redundant choice narrowing
vineethsaivs 6db73ae
fix(guardrails): check every Noma response choice
vineethsaivs 93c8d9e
test(guardrails): isolate the Noma test HTTP client
vineethsaivs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.