Skip to content

test(e2e): skip view-backed global spend probes pending LIT-5211 #35875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuneng-berri merged 1 commit into from
Aug 5, 2026
Merged

test(e2e): skip view-backed global spend probes pending LIT-5211 #35875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion tests/e2e/quota_management/spend_tracking/test_spend_routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,24 @@

_SPEND_PREFIXES = ("/spend", "/global/spend", "/global/activity")

_MISSING_VIEW_SKIP = pytest.mark.skip(
reason=(
"LIT-5211: on a fresh database the proxy's startup view creation can lose the race "
"against schema migrations, leaving MonthlyGlobalSpend/DailyTagSpend/Last30d* views "
"missing and these routes 500ing until the views exist"
)
)

_VIEW_BACKED_ROUTES = frozenset(
(
"/global/spend",
"/global/spend/keys",
"/global/spend/models",
"/global/spend/tags",
"/global/spend/logs",
)
)


def _date_range() -> DateRangeParams:
# Satisfies date-required endpoints (report/activity/provider); ignored elsewhere.
Expand All @@ -80,7 +98,13 @@ def _date_range() -> DateRangeParams:
return DateRangeParams(start_date=start.isoformat(), end_date=end.isoformat())


@pytest.mark.parametrize("route", SPEND_ROUTES)
@pytest.mark.parametrize(
"route",
tuple(
pytest.param(route, marks=_MISSING_VIEW_SKIP) if route in _VIEW_BACKED_ROUTES else route
for route in SPEND_ROUTES
),
Comment on lines +104 to +106

@greptile-apps greptile-apps Bot Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Unconditional skips remove route coverage

Every route in _VIEW_BACKED_ROUTES receives an unconditional skip, so even healthy stacks no longer run the existing 404 and 5xx checks for these five endpoints, allowing endpoint regressions to pass this E2E suite unnoticed.

Rule Used: What: Flag any modifications to existing tests and... (source)

)
def test_spend_route_responsive(client: SpendClient, route: str) -> None:
result = client.probe(route, params=_date_range())
print(f"{route} -> {result.status_code}\n{result.body[:600]}")
Expand Down
Loading