test(e2e): skip the strict-priority and throughput SLO tests pending LIT-5118 / LIT-5119 - #35575
Merged
yuneng-berri merged 1 commit intoAug 2, 2026
Conversation
…LIT-5118 / LIT-5119 The strict-priority e2e (added with the zero-increment limiter fix) can never pass on stage: the proxy there does not run the dynamic_rate_limiter_v3 callbacks + priority_reservation settings the module requires, confirmed by zero limiter log lines across every gateway and backend pod during the 2026-08-02 run. Config lives in the infra repo; LIT-5118 tracks adding it. The throughput SLO test failed the same run with 65.9% of requests dying at the ELB as 502/503 before reaching a pod. The per-replica SLO rework fixed the RPS-floor assertion but cannot help when stage idles at one warm gateway replica; LIT-5119 tracks pre-scaling the fleet for the load phase. Both skips name their ticket, and the coverage registry returns the two cells to the gap list while they are in place.
yuneng-berri
approved these changes
Aug 2, 2026
Contributor
Greptile SummaryThis PR temporarily skips two environment-blocked end-to-end tests while preserving honest coverage-registry reporting.
Confidence Score: 5/5The PR appears safe to merge because it makes only the explicitly intended test skips and does not falsely preserve their coverage status. The coverage collector recognizes both skipped tests as uncovered, decorator order does not alter that behavior, and the remaining generous-priority test covers a separate scenario as described.
|
| Filename | Overview |
|---|---|
| tests/e2e/load/test_chat_completions_throughput_e2e.py | Adds a ticket-referenced unconditional skip to the environment-blocked throughput SLO test; skipped coverage is correctly returned to the registry gap list. |
| tests/e2e/quota_management/ratelimit/test_dynamic_rate_limit_priority_e2e.py | Adds a ticket-referenced unconditional skip to the strict-priority test while retaining the distinct generous-mode test and honest registry accounting. |
Reviews (1): Last reviewed commit: "test(e2e): skip the strict-priority and ..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
How it solves it:
Relevant issues
Linear ticket
Refs LIT-5118, LIT-5119
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
Both failures are from the stage run 2026-08-02 00:52 UTC (pod litellm-e2e-1-0-0-main-20260802005210-s4d6g, image at ba480a6), the run's only failures besides the budget reset flake fixed in #35572
The strict-priority failure is config, not code: Loki across every gateway and backend pod in the window has zero lines matching
dynamic_rate_limiter|priority_reservation|Priority-based(73,922 scanned), so the limiter callback is not running on stage at all. The load failure is the LIT-5054 capacity story on its other assertion; the requests died at the ELB before reaching a podAfter (at the PR commit), both deselect cleanly with no proxy involved:
Type
✅ Test
Changes
Adds a
@pytest.mark.skipnaming the blocking ticket totest_strict_mode_blocks_saturated_priority_but_serves_the_other(LIT-5118: stage needs thedynamic_rate_limiter_v3callbacks pluspriority_reservationsettings in the infra repo config) and totest_sustains_throughput_slo_under_load(LIT-5119: stage refuses the closed-loop load at the ELB until the fleet is pre-scaled for the load phase). No assertion changes. Per the coverage-registry rules a skipped test returns its cell to the gap list, soquota_management.ratelimit.priority_strict.picks_under_tpmandreliability.perf.throughput.under_slowill report as uncovered rather than greenThe generous-mode sibling stays enabled: it asserts the absence of a 429 below the saturation threshold, which holds with or without the limiter, so it cannot go red for this config gap (noted in LIT-5118 that its green is not evidence the feature works on stage)
QA runbook
Final Attestation