build(makefile): run bootstrap before pre-commit lint - #35547
Merged
mateo-berri merged 1 commit intoAug 2, 2026
Conversation
Contributor
Greptile SummaryThis PR makes
Confidence Score: 5/5The PR appears safe to merge, with the added provisioning behavior matching the documented purpose of the pre-commit workflow. The change reuses the existing bootstrap target before linting, and the resulting setup work and warm-run overhead are intentional and documented without exposing a concrete broken caller.
|
| Filename | Overview |
|---|---|
| Makefile | Adds the existing bootstrap target as a prerequisite of pre-commit; no actionable regression was identified. |
Reviews (1): Last reviewed commit: "build(makefile): run bootstrap before pr..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
tin-berri
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
make pre-commitassumes deps are already provisionedHow it solves it:
pre-commitnow runsbootstrapfirstRelevant issues
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
Before, at base b1fd20f:
make pre-commitgoes straight to the lint script, so it inherits whatever state the venv and node_modules happen to be inAfter, at 28d56ef: bootstrap runs first and a warm run adds about 1.5 seconds before the lint script starts
Type
🚄 Infrastructure
Changes
pre-commitgainsbootstrapas a make prerequisite (both are already.PHONY), so the environment is synced right before the gating lint checks run. Since #35509 made the dashboard install incremental, the fully warm case costs about 1.5 seconds, dominated by npm confirming node_modules is up to date; when deps actually drifted, that is exactly the case where you want bootstrap to run before linting