chore(proxy): remove duplicate Sequence import in team endpoints - #35479
Merged
yuneng-berri merged 1 commit intoAug 1, 2026
Merged
Conversation
Contributor
Greptile SummaryRemoves the duplicate
Confidence Score: 5/5The PR appears safe to merge because it only removes a duplicate import while preserving the symbol used by existing annotations
|
| Filename | Overview |
|---|---|
| litellm/proxy/management_endpoints/team_endpoints.py | Safely removes a redundant Sequence import; no behavioral, typing, or security regression was identified |
Reviews (1): Last reviewed commit: "chore(proxy): remove duplicate Sequence ..." | Re-trigger Greptile
yuneng-berri
enabled auto-merge
August 1, 2026 19:20
ryan-crabbe-berri
approved these changes
Aug 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
team_endpoints.pytrips ruff F811 on stagingSequenceis imported from bothcollections.abcandtypingtypingcopy shadows the one every annotation readsHow it solves it:
Sequencefrom thetypingimport blockfrom collections.abc import SequenceRelevant issues
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
@greptileaito re-request a review after pushing changes)No test is added here on purpose.
F811is enforced repo-wide bymake lint, so reintroducing the duplicate import turns CI red on its own; a unit test asserting the shape of an import block would assert nothing the linter does not already catchDelays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
This change removes a shadowed import name; it has no request path and no runtime behavior to exercise, so the proof is the linter that currently fails
Before, at
1e7b39d15c(currentlitellm_internal_staginghead):git show 1e7b39d15c:litellm/proxy/management_endpoints/team_endpoints.py | uv run ruff check --stdin-filename litellm/proxy/management_endpoints/team_endpoints.py -After, at
c541fb2b7a(this PR):Full
make pre-commiton the branch also passes: ruff, the strict / type-discipline / basedpyright budget gates, the circular-import check, format, and the dashboard API type syncType
🐛 Bug Fix
Changes
from collections.abc import Sequencelanded ine8e2e07ef6(#35435) whileSequencewas already in the file'stypingimport block, and the two only met when that PR merged into staging, so the duplicate reached staging without either side seeing it. All 11 uses in the file are subscripted generics (Sequence[Member]and friends), which behave identically under both spellings, so keeping thecollections.abcone and deleting thetypingone is a no-op at runtimeFinal Attestation