Skip to content

test(e2e): skip passthrough headers test until stage can route custom paths to provider creds #34980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shin-berri merged 1 commit into from
Jul 28, 2026
Merged

test(e2e): skip passthrough headers test until stage can route custom paths to provider creds #34980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/e2e/llm_translation/test_passthrough_headers_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@ def _messages_body() -> AnthropicMessagesBody:


class TestPassthroughHeaders:
@pytest.mark.skip(
reason="stage red: ALB sends custom passthrough paths to backend pods, which lack ANTHROPIC_API_KEY, "
"so the os.environ header forwards unresolved and Anthropic 401s; routing user-defined paths to the "
"gateway needs a product/infra decision (fixed path namespace or dynamic ingress)"
)
Comment on lines +99 to +103

@greptile-apps greptile-apps Bot Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Stage skip disables all coverage

The unconditional pytest.mark.skip also disables this passthrough-header regression test locally and in environments where custom paths reach gateway pods with provider credentials, leaving the behavior untested outside the affected stage setup. Restrict the skip to the stage environment exhibiting the routing gap so capable environments retain the regression coverage.

Rule Used: What: Flag any modifications to existing tests and... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@pytest.mark.covers(
"other.config.passthrough.headers_forwarded",
exercised_on=[],
Expand Down
Loading