Repository navigation
fix(mcp): authorize UI sessions as live users #34585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,6 +48,11 @@ async def resolve_ui_session_team_ids( | |
| prisma_client=prisma_client, | ||
| user_api_key_cache=user_api_key_cache, | ||
| user_id_upsert=False, | ||
| # UI-session authorization must observe grants, revocations, and | ||
| # offboarding on the next request. A cached user row can retain a | ||
| # pre-login or pre-reconciliation team list until its management | ||
| # TTL expires, which makes both grants and revocations stale. | ||
| check_db_only=True, | ||
| parent_otel_span=user_api_key_auth.parent_otel_span, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Setting Rule Used: What: Avoid creating new database requests or Rout... (source) Knowledge Base Used: Proxy Authentication and Authorization |
||
| proxy_logging_obj=proxy_logging_obj, | ||
| ) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This explanatory comment violates the repository-wide instruction against adding code comments unless explicitly requested, creating avoidable policy cleanup for an otherwise self-contained change
Context Used: CLAUDE.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!