fix(ci): bump js-yaml override to 4.3.0 to clear osv-scan GHSA-52cp-r559-cp3m - #34039
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(ci): bump js-yaml override to 4.3.0 to clear osv-scan GHSA-52cp-r559-cp3m#34039cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…559-cp3m osv-scan started failing after js-yaml 4.2.0 (High 7.5, npm dev dep pulled via the dashboard) entered the OSV database. The fix release is 4.3.0, and package.json already pins js-yaml via an override, so bump the pin and mirror the resolved/integrity in package-lock.json for the single node_modules/js-yaml entry. npm ci --dry-run validates the lockfile Co-authored-by: Krrish Dholakia <krrish-berri-2@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issues
overridesinui/litellm-dashboard/package.json, so bumping the pinned version there plus mirroring the resolved/integrity for the singlenode_modules/js-yamlentry inpackage-lock.jsonis all that's needed;npm ci --dry-runvalidates the lockfileLinear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
Ran the same osv-scanner v2.3.8 invocation the workflow uses locally against this branch. Before the bump (litellm_internal_staging @ eb27447), osv-scan reports two flags; after the bump the js-yaml row is gone and only the brace-expansion flag remains (already fixed by #34032):
Type
🚄 Infrastructure
Changes
ui/litellm-dashboard/package.json:overrides.js-yaml4.2.0 -> 4.3.0ui/litellm-dashboard/package-lock.json:node_modules/js-yamlversion/resolved/integrity updated to match 4.3.0; nothing else touchedFinal Attestation