Skip to content

chore(e2e): remove tests/e2e/docker-compose.yml - #33837

Merged
mubashir1osmani merged 3 commits into
litellm_internal_stagingfrom
litellm_delete_e2e_docker_compose
Jul 18, 2026
Merged

chore(e2e): remove tests/e2e/docker-compose.yml#33837
mubashir1osmani merged 3 commits into
litellm_internal_stagingfrom
litellm_delete_e2e_docker_compose

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Relevant issues

Linear ticket

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have added meaningful tests
  • My PR passes all CI/CD checks (e.g., lint, format, unit tests)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review (Greptile reviews automatically once the PR is opened; only comment @greptileai to re-request a review after pushing changes)

Type

🧹 Refactoring

Changes

Deletes tests/e2e/docker-compose.yml and repoints the contributor docs at running the litellm proxy locally instead of docker compose up

The deleted compose was the e2e harness's stack, not a duplicate of the root docker-compose.yml (the root one is a general local-dev deploy: builds from source, persistent Postgres, Prometheus, no inline proxy config or models). With it gone, tests/e2e/CONTRIBUTING.md and tests/e2e/CLAUDE.md now tell contributors to stand up a Postgres and Redis, point a .env at them, and run litellm --config <your-e2e-config>.yml --port 4000, then run the suite against http://localhost:4000. The docs also call out the services individual suites still need (a jaeger for the OTEL logging tests, the upstream MCP server for the mcp suite)

Scope note: this does not ship a replacement e2e proxy config, so contributors supply their own config wiring the example models the suites read back (gpt-5.5, claude-haiku-4-5, gemini-2.5-flash, openai-text-embedding-3-small, complexity-smart-router). Inline code comments in a few tests still mention the old docker-compose.yml (e2e_config.py, router/conftest.py, router/test_complexity_router_e2e.py, management/test_key_models_dropdown_e2e.py, claude_code/conftest.py, the budget-window tests); left untouched here to keep the change to the two contributor docs

Final Attestation

  • The tests check the right things, including the edge cases, and regressions in the respective real-world customer use-cases are not possible after this PR

Link to Devin session: https://app.devin.ai/sessions/60e23180816b42af9de38382c30e2ccc
Requested by: @yassin-berriai

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@yassin-berriai yassin-berriai self-assigned this Jul 18, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mubashir1osmani
mubashir1osmani enabled auto-merge (squash) July 18, 2026 19:06
@greptile-apps

greptile-apps Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR deletes tests/e2e/docker-compose.yml, the e2e harness's compose stack that stands up LiteLLM proxy, Postgres, Redis, Jaeger, and a FastMCP upstream for local integration testing. The deletion is explicitly isolated at the requester's direction, with follow-up cleanup of dangling references promised separately.

  • The removed file is the sole entrypoint for running e2e suites locally; CONTRIBUTING.md, CLAUDE.md, e2e_config.py, and several test/conftest files all reference it directly by name.
  • Without a replacement entrypoint landing in the same commit, docker compose up -d from tests/e2e/ fails immediately and no e2e suite can be run locally until the follow-up lands.

Confidence Score: 3/5

Merging this breaks the local e2e development workflow for all contributors until a follow-up lands; no production code is affected.

The deletion removes the only local-dev entrypoint for the entire e2e suite. CONTRIBUTING.md, CLAUDE.md, e2e_config.py, and multiple test files all reference this compose file by name. Any contributor following the documented setup steps after this merges will immediately hit a missing file. The PR itself acknowledges the dangling references and defers cleanup to a follow-up, but until that follow-up lands the e2e directory is in an inconsistent state — the docs say 'run docker compose up -d' and the file simply isn't there.

tests/e2e/docker-compose.yml is the only changed file; the concern is the downstream impact on CONTRIBUTING.md, CLAUDE.md, e2e_config.py, and several test conftest files that all reference it.

Important Files Changed

Filename Overview
tests/e2e/docker-compose.yml Deletes the e2e harness's compose stack (Postgres, Redis, Jaeger, FastMCP upstream, LiteLLM proxy), leaving docker compose up -d from tests/e2e/ broken and all references in CONTRIBUTING.md, CLAUDE.md, e2e_config.py, and multiple test files dangling.

Comments Outside Diff (1)

  1. tests/e2e/docker-compose.yml

    P1 Dangling references break local e2e setup

    Removing this file leaves the contributor workflow in a broken state. CONTRIBUTING.md instructs contributors to run docker compose up -d from tests/e2e/ as step 2 of local setup, and step 2 of the pre-commit checklist says "Add the models your test needs to the inline config in docker-compose.yml". CLAUDE.md has a hard rule: "use the docker-compose to your advantage and spin up a local proxy, make sure all tests pass." e2e_config.py has an inline comment tying OTEL_QUERY_URL to the compose stack's jaeger service port mapping. Several test conftest files and budget-reset tests also reference docker compose. Without a replacement entrypoint landing in the same commit, any contributor following the documented setup steps will hit a missing file immediately.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Reviews (1): Last reviewed commit: "chore(e2e): remove tests/e2e/docker-comp..." | Re-trigger Greptile

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

yassin-berriai and others added 2 commits July 18, 2026 19:15
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…r_compose

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@codspeed-hq

codspeed-hq Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 31 untouched benchmarks


Comparing litellm_delete_e2e_docker_compose (9ff363b) with litellm_internal_staging (fdf380d)

Open in CodSpeed

@mubashir1osmani
mubashir1osmani merged commit 66dea7d into litellm_internal_staging Jul 18, 2026
76 checks passed
@mubashir1osmani
mubashir1osmani deleted the litellm_delete_e2e_docker_compose branch July 18, 2026 19:50
mateo-berri added a commit that referenced this pull request Jul 22, 2026
Adapt the Azure OpenAI chat coverage onto the refactored e2e harness:
drop tests/e2e/docker-compose.yml (removed upstream in #33837) and register
the Azure deployments via /model/new inside the test with teardown, keep the
upstream stream_events transport and add a stream_done terminator flag, port
the ChatStreamChunk models, and extend LiteLLMParamsBody/ModelInfoBody with
the max_tokens, drop_params, and base_model fields the Azure cases need

Also drop the strict xfail from
test_azure_config_token_cap_with_client_max_completion_tokens now that
GH #31614 is fixed: AzureOpenAIConfig.map_openai_params skips max_tokens
when the client also sends max_completion_tokens (PR #34214), so the row
asserts the completion succeeds and guards against regression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants