-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
feat(router): add router plugin reference catalog #33746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| [ | ||
| { | ||
| "name": "TEMPLATE: copy this block for a new plugin, then delete this entry", | ||
| "description": "One line on what the plugin does and the routing signal it publishes.", | ||
| "author": "Plugin author's name.", | ||
| "repo": "https://github.com/<owner>/<repo> (public source repository).", | ||
| "commit": "Full 40-char git SHA to pin when the plugin is not yet on PyPI; omit once 'pypi' is set.", | ||
| "version": "Plugin release version, e.g. 1.0.0.", | ||
| "pypi": "PyPI spec pinned to a version, e.g. my-plugin==1.0.0, or null if unpublished.", | ||
| "litellm_version": "Minimum compatible litellm version, e.g. >=1.94.0.", | ||
| "entrypoint": "Dotted import path to the plugin instance, e.g. my_plugin.plugin.instance.", | ||
| "license": "SPDX license id, e.g. MIT.", | ||
| "tags": ["searchable", "keywords"] | ||
| }, | ||
| { | ||
| "name": "language-detector", | ||
| "description": "Detects the user's language and publishes a routing signal.", | ||
| "author": "Jean Nuñez", | ||
| "repo": "https://github.com/jeann2013/language-detector", | ||
| "commit": "9e712819269173fc25a16f59ca3e9890f7864ac1", | ||
| "version": "1.0.0", | ||
| "pypi": null, | ||
| "litellm_version": ">=1.94.0", | ||
| "entrypoint": "litellm_plugin_language_detector.plugin.language_detector_plugin", | ||
| "license": "MIT", | ||
| "tags": ["language", "classification", "routing"] | ||
| } | ||
| ] | ||
|
Comment on lines
+1
to
+28
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There is no accompanying JSON Schema (e.g., |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR describes this file as a "machine-readable reference catalog," yet the first array element is a template with several fields containing descriptive prose instead of valid data values. Concretely,
pypiis set to the string"PyPI spec pinned to a version, e.g. my-plugin==1.0.0, or null if unpublished."instead ofnull,repocontains<owner>/<repo>placeholder text (not a valid URL),versionandlicensehold sentence-length instructions, andentrypointis not a dotted import path. Any tool that iterates the array treating every element as a real plugin entry will see this as a plugin to load or install, and will either crash or attempt nonsensical operations (e.g.,pip install "PyPI spec pinned to a version...").