Skip to content

test(e2e): delete unreferenced Grafana panel docs - #33743

Merged
mubashir1osmani merged 1 commit into
litellm_internal_stagingfrom
litellm_lit4553_delete_grafana_panel_docs
Jul 17, 2026
Merged

test(e2e): delete unreferenced Grafana panel docs#33743
mubashir1osmani merged 1 commit into
litellm_internal_stagingfrom
litellm_lit4553_delete_grafana_panel_docs

Conversation

@yassin-berriai

@yassin-berriai yassin-berriai commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Relevant issues

Linear ticket

Resolves LIT-4553

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have added meaningful tests (N/A: this deletes an unreferenced markdown doc; see Proof of Fix for why no test applies)
  • My PR passes all CI/CD checks (e.g., lint, format, unit tests) (all green except the pre-existing repo-wide osv-scan, which is red on other open PRs too and is unaffected by this doc-only diff)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review (Greptile reviews automatically once the PR is opened; only comment @greptileai to re-request a review after pushing changes)

Screenshots / Proof of Fix

This is a deletion of an unreferenced markdown doc, so there is no runtime behavior to exercise. The proof is that the file existed on the base branch, is gone at HEAD, and nothing in the tree references it. No meaningful automated test applies to "an unreferenced doc no longer exists"; a test asserting the absence of a file would be hollow, so none was added. The regression this guards against (a stray dashboard-as-prose doc drifting from the real Grafana dashboard) is prevented by removing the file, not by a test

Base: litellm_internal_staging. Proof captured at commit da9bb2b391

The file existed on base and is gone at HEAD:

$ git ls-tree origin/litellm_internal_staging tests/e2e/grafana/status_history_panels.md
100644 blob f8cda509c6313a76ae0d60fa3004d4babde47a96	tests/e2e/grafana/status_history_panels.md
$ git ls-files tests/e2e/grafana/
                       # empty: the file was the only thing in the directory, so the dir is gone too

Zero references anywhere in the repo (code, CI configs, mkdocs, other markdown):

$ rg -n "status_history_panels|e2e/grafana" --hidden -g '!.git'
                       # no matches (rg exit 1)

The two e2e modules that mention Grafana never depended on the doc; they only emit the E2E_RESULT logfmt lines the panels consume, and they still parse cleanly after the deletion:

$ python3.13 -c "import ast; ast.parse(open('tests/e2e/e2e_result_reporter.py').read()); ast.parse(open('tests/e2e/conftest.py').read()); print('parse OK')"
parse OK

Type

🧹 Refactoring

Changes

Deletes tests/e2e/grafana/status_history_panels.md, which was prose describing Loki/Grafana status-history panels and their LogQL queries. Nothing in the tree imports, reads, or links to it; the e2e suite only emits the E2E_RESULT lines those panels consume (tests/e2e/conftest.py, tests/e2e/e2e_result_reporter.py) and never depends on the markdown. Dashboards drift when they are versioned as prose in the code repo, so it should not live here. If we want the dashboards versioned, the right home is dashboard-as-code (Grafana JSON model / Terraform) in the observability repo, not markdown in this one

The file was the only entry in tests/e2e/grafana/, so that directory is removed as well

Final Attestation

  • The tests check the right things, including the edge cases, and regressions in the respective real-world customer use-cases are not possible after this PR (deleting an unreferenced doc changes no runtime behavior and no customer-facing path)

tests/e2e/grafana/status_history_panels.md was prose describing Loki/Grafana
status-history panels and LogQL queries. Nothing in the tree imports, reads, or
links to it; the e2e suite only emits the E2E_RESULT lines those panels consume
(tests/e2e/conftest.py, tests/e2e/e2e_result_reporter.py) and never depends on
this file. Dashboards drift when versioned as prose in the repo, so remove it;
if we want them versioned it should be dashboard-as-code in the observability
repo, not markdown here.
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@CLAassistant

CLAassistant commented Jul 17, 2026

Copy link
Copy Markdown

CLA assistant check)
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement) before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck) it.

@greptile-apps

greptile-apps Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes tests/e2e/grafana/status_history_panels.md, a prose document describing Loki/Grafana status-history panels and their LogQL queries, along with the now-empty tests/e2e/grafana/ directory. No code, CI config, or other markdown file references the deleted file.

  • The deletion is consistent with the repository rule that documentation belongs in the litellm-docs repo rather than here.
  • The two e2e modules that emit E2E_RESULT logfmt lines (conftest.py, e2e_result_reporter.py) never depended on this doc and are unaffected.

Confidence Score: 5/5

Safe to merge — deletes only an unreferenced markdown doc with no impact on runtime behavior or CI.

The change removes a single markdown file that no code, CI config, or other document depends on. Nothing is altered in the runtime path, test logic, or any importable module. The deletion also aligns with the repo policy of keeping documentation in the dedicated docs repo.

No files require special attention.

Important Files Changed

Filename Overview
tests/e2e/grafana/status_history_panels.md Deleted unreferenced Grafana/Loki panel documentation — nothing in the repo imports or links to it, and the deletion is consistent with the rule that docs belong in the litellm-docs repo.

Reviews (1): Last reviewed commit: "test(e2e): delete unreferenced Grafana p..." | Re-trigger Greptile

@codspeed-hq

codspeed-hq Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 31 untouched benchmarks


Comparing litellm_lit4553_delete_grafana_panel_docs (da9bb2b) with litellm_internal_staging (a7d01cb)1

Open in CodSpeed

Footnotes

  1. No successful run was found on litellm_internal_staging (e5a9f3f) during the generation of this report, so a7d01cb was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@mubashir1osmani
mubashir1osmani merged commit ad65cad into litellm_internal_staging Jul 17, 2026
78 of 79 checks passed
@mubashir1osmani
mubashir1osmani deleted the litellm_lit4553_delete_grafana_panel_docs branch July 17, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants