test(e2e): delete unreferenced Grafana panel docs - #33743
Conversation
tests/e2e/grafana/status_history_panels.md was prose describing Loki/Grafana status-history panels and LogQL queries. Nothing in the tree imports, reads, or links to it; the e2e suite only emits the E2E_RESULT lines those panels consume (tests/e2e/conftest.py, tests/e2e/e2e_result_reporter.py) and never depends on this file. Dashboards drift when versioned as prose in the repo, so remove it; if we want them versioned it should be dashboard-as-code in the observability repo, not markdown here.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
|
Greptile SummaryThis PR removes
Confidence Score: 5/5Safe to merge — deletes only an unreferenced markdown doc with no impact on runtime behavior or CI. The change removes a single markdown file that no code, CI config, or other document depends on. Nothing is altered in the runtime path, test logic, or any importable module. The deletion also aligns with the repo policy of keeping documentation in the dedicated docs repo. No files require special attention.
|
| Filename | Overview |
|---|---|
| tests/e2e/grafana/status_history_panels.md | Deleted unreferenced Grafana/Loki panel documentation — nothing in the repo imports or links to it, and the deletion is consistent with the rule that docs belong in the litellm-docs repo. |
Reviews (1): Last reviewed commit: "test(e2e): delete unreferenced Grafana p..." | Re-trigger Greptile
ad65cad
into
litellm_internal_staging
Relevant issues
Linear ticket
Resolves LIT-4553
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
osv-scan, which is red on other open PRs too and is unaffected by this doc-only diff)@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
This is a deletion of an unreferenced markdown doc, so there is no runtime behavior to exercise. The proof is that the file existed on the base branch, is gone at HEAD, and nothing in the tree references it. No meaningful automated test applies to "an unreferenced doc no longer exists"; a test asserting the absence of a file would be hollow, so none was added. The regression this guards against (a stray dashboard-as-prose doc drifting from the real Grafana dashboard) is prevented by removing the file, not by a test
Base:
litellm_internal_staging. Proof captured at commitda9bb2b391The file existed on base and is gone at HEAD:
Zero references anywhere in the repo (code, CI configs, mkdocs, other markdown):
The two e2e modules that mention Grafana never depended on the doc; they only emit the
E2E_RESULTlogfmt lines the panels consume, and they still parse cleanly after the deletion:Type
🧹 Refactoring
Changes
Deletes
tests/e2e/grafana/status_history_panels.md, which was prose describing Loki/Grafana status-history panels and their LogQL queries. Nothing in the tree imports, reads, or links to it; the e2e suite only emits theE2E_RESULTlines those panels consume (tests/e2e/conftest.py,tests/e2e/e2e_result_reporter.py) and never depends on the markdown. Dashboards drift when they are versioned as prose in the code repo, so it should not live here. If we want the dashboards versioned, the right home is dashboard-as-code (Grafana JSON model / Terraform) in the observability repo, not markdown in this oneThe file was the only entry in
tests/e2e/grafana/, so that directory is removed as wellFinal Attestation