-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
fix(embeddings): accept encoding_format="float" for vertex_ai/gemini embeddings #33617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
krrish-berri-2
merged 1 commit into
litellm_oss_daily_2026_07_16
from
litellm_/vertex-embeddings-float-33293
Jul 17, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
llms/directoryThe encoding-format stripping is added directly to
utils.pyrather than to the provider's own config class.VertexAITextEmbeddingConfig(inlitellm/llms/vertex_ai/vertex_embeddings/transformation.py) already owns bothget_supported_openai_params()andmap_openai_params()— the correct fix is to add"encoding_format"to the supported-params list and silently drop it (when"float") insidemap_openai_params(). Placing the strip logic inutils.pymeans the behaviour won't automatically apply when the provider eventually gets aBaseEmbeddingConfigregistration inget_provider_embedding_config(the early-return path would then bypass these lines entirely).Rule Used: What: Avoid writing provider-specific code outside... (source)