Skip to content

refactor(e2e): type the claude_code suite and drop its basedpyright exclusion #33480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mateo-berri wants to merge 2 commits into
base: litellm_internal_staging
Choose a base branch
from
Open

refactor(e2e): type the claude_code suite and drop its basedpyright exclusion #33480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
949aa53
refactor(e2e): type claude_code suite core modules under strict based…
mateo-berri Jul 15, 2026
cfa7f54
refactor(e2e): type remaining claude_code suite files and drop pyrigh…
mateo-berri Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyrightconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"include": ["litellm"],
"ignore": [],
"exclude": ["**/node_modules", "**/__pycache__", "tests/e2e/claude_code", "litellm/types/utils.py", "litellm/proxy/_types.py"],
"exclude": ["**/node_modules", "**/__pycache__", "litellm/types/utils.py", "litellm/proxy/_types.py"],
"pythonVersion": "3.12",
"typeCheckingMode": "strict",
"enableTypeIgnoreComments": false,
Expand Down
10 changes: 6 additions & 4 deletions tests/e2e/claude_code/_basic_messaging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from __future__ import annotations

import os
from typing import Any, Mapping, Sequence
from typing import Mapping, Sequence

import pytest

Expand All @@ -37,6 +37,8 @@
failure_diagnostic,
run_claude_models_parallel,
)
from claude_code.conftest import CompatResult
from claude_code.json_types import JSONValue

PROXY_BASE_URL_ENV = "LITELLM_PROXY_BASE_URL"
PROXY_API_KEY_ENV = "LITELLM_PROXY_API_KEY"
Expand All @@ -53,7 +55,7 @@
MIN_STREAM_DELTA_EVENTS = 2


def _count_stream_event_deltas(events: Sequence[Mapping[str, Any]]) -> int:
def _count_stream_event_deltas(events: Sequence[Mapping[str, JSONValue]]) -> int:
"""Count `stream_event` records that carry an SSE event payload.

With `--include-partial-messages`, Claude Code wraps every upstream
Expand All @@ -75,7 +77,7 @@ def _count_stream_event_deltas(events: Sequence[Mapping[str, Any]]) -> int:

def run_basic_messaging_cell(
*,
compat_result,
compat_result: CompatResult,
models: Sequence[str],
prompt: str,
verify_streaming: bool = False,
Expand Down Expand Up @@ -128,7 +130,7 @@ def run_basic_messaging_cell(
extra_args=extra_args,
)

failures = []
failures: list[str] = []
for model in models:
outcome = outcomes[model]
if isinstance(outcome, ClaudeCLIError):
Expand Down
Loading
Loading