-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
fix(guardrails): run apply_guardrail-style model-level pre_call guardrails at deployment hook #33136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yucheng-berri
merged 3 commits into
litellm_internal_staging
from
litellm_lit4217_model_guardrail_precall
Jul 14, 2026
+123
−2
Merged
fix(guardrails): run apply_guardrail-style model-level pre_call guardrails at deployment hook #33136
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
962c495
fix(guardrails): run apply_guardrail-style model-level pre_call guard…
yucheng-berri a89f9af
fix(guardrails): keep request-body dispatch predicate unchanged
yucheng-berri d2f401a
fix(guardrails): fail closed when proxy extras are missing at deploym…
yucheng-berri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the repo's backwards-compatibility rule, behaviour changes should be gated behind a user-controlled flag. Guardrails that override both
async_pre_call_hookandapply_guardrail(e.g. presidio, bedrock, panw_prisma_airs, enkryptai) and are attached at the model level previously executed their ownasync_pre_call_hookat this stage; they now route throughunified_guardrail → apply_guardrailinstead. The PR acknowledges this under "Behavior changes" but provides no opt-out. If any of those guardrails produce different results across the two paths (e.g. presidio PII scrubbing vs. itsapply_guardrailvariant), existing model-level attachments will silently change behaviour after upgrade.Rule Used: What: avoid backwards-incompatible changes without... (source)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acknowledged as an intentional alignment rather than gated behind a flag: the request-body path already dispatches these four guardrails through apply_guardrail, so a flag would preserve a divergence with no value. Live parity evidence for presidio, bedrock and enkryptai (identical output on every path, before and after) is in the PR description under Dual-override guardrail parity