fix(xecguard): use StandardLoggingGuardrailInformation in logging hook - #32907
Closed
yucheng-berri wants to merge 1 commit into
Closed
fix(xecguard): use StandardLoggingGuardrailInformation in logging hook#32907yucheng-berri wants to merge 1 commit into
yucheng-berri wants to merge 1 commit into
Conversation
Closes LIT-4335. XecGuard's async_logging_hook wrote a bare dict to standard_logging_object['guardrail_information'] instead of a properly typed StandardLoggingGuardrailInformation wrapped in a list. This broke downstream loggers (Langfuse, Datadog LLM Obs, etc.) that expect a List[StandardLoggingGuardrailInformation] — they would iterate keys instead of entries, or skip guardrail duration rollup entirely. - Construct a StandardLoggingGuardrailInformation TypedDict - Wrap in a list or append to existing list (consistent with add_standard_logging_guardrail_information_to_request_data) - Update existing test assertions to validate the list-of-dict shape
|
|
Contributor
Author
|
Closed and recreated as #32911 on a litellm_ prefixed branch with corrected commit authorship |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes LIT-4335.
XecGuard's
async_logging_hookwrote a bare dict tostandard_logging_object['guardrail_information']instead of a properly typedStandardLoggingGuardrailInformationwrapped in a list. This broke downstream loggers that expectList[StandardLoggingGuardrailInformation].Changes:
StandardLoggingGuardrailInformationTypedDict