test(e2e): drop vertex from pipecat tool smoke and remove key models dropdown suite - #32839
Conversation
Exclude vertex_ai from pipecat tool smoke; raw-ws tool_call_round_trip remains the Vertex source of truth. Also remove the Playwright key models dropdown suite so stage is not blocked by that UI harness
Greptile SummaryThis PR trims two e2e suites on the staging branch: it excludes
Confidence Score: 3/5The realtime pipecat change is safe; the UI test deletion leaves key/team model-scope enforcement entirely untested with no stated plan to restore it. The pipecat vertex exclusion is well-justified and backed by raw-ws coverage. The deletion of test_key_models_dropdown_e2e.py is the concern: it removes the only automated verification that the backend correctly scopes model sentinels for teamless vs team keys, and the PR neither explains why those tests are broken nor tracks when they will come back. tests/e2e/management/test_key_models_dropdown_e2e.py — understand why these tests were failing before accepting their removal.
|
| Filename | Overview |
|---|---|
| tests/e2e/management/test_key_models_dropdown_e2e.py | Entire Playwright UI suite for key/team model-scope enforcement deleted to unblock stage CI; no root-cause explanation or restore plan provided, leaving scope-enforcement untested. |
| tests/e2e/llm_translation/realtime/test_realtime_pipecat_e2e.py | Drops vertex_ai from PROVIDER_PARAMS for pipecat tool smoke; justified by upstream pipecat issue #2544 while raw-ws test_tool_call_round_trip[vertex_ai] retains authoritative coverage. |
| tests/e2e/llm_translation/realtime/REALTIME_COVERAGE_MATRIX.md | Documentation updated to reflect vertex_ai exclusion from pipecat tool smoke, add reference to audio coverage file, and correct xai model name to grok-4-1-fast-non-reasoning. |
Comments Outside Diff (1)
-
tests/e2e/management/test_key_models_dropdown_e2e.pyUI test coverage gap with no restore plan
The entire file is deleted to unblock stage, but the PR doesn't state why these four tests are failing (flaky selector, missing
gpt-5.5in the stage proxy config, a Playwright version issue, etc.) and there is no follow-up ticket or companion PR to restore the coverage. These tests verify the key create/edit models-dropdown scoping rules — that a teamless key sees onlyAll Proxy Models, a team key sees onlyAll Team Models, and that the backend persists the correct sentinel — behavior that has no other automated coverage. Dropping all four tests without explaining the root cause or providing an issue to track re-enabling them leaves the scope-enforcement contract untested.Rule Used: What: Flag any modifications to existing tests and... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Reviews (1): Last reviewed commit: "test(e2e): drop vertex from pipecat tool..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Moved to a same-repo BerriAI branch (no longer cross-fork) |
Pull request was closed
Relevant issues
Linear ticket
Pre-Submission checklist
@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
Stage e2e log from before this change:
test_tool_call_round_trip[vertex_ai]PASSED (raw GA websocket through LiteLLM)test_pipecat_tool_smoke[openai|azure|gemini]PASSEDtest_pipecat_tool_smoke[vertex_ai]FAILED withpipecat did not invoke the get_weather callbackSame pattern as pipecat-ai/pipecat#2544. Rebuild the stage e2e image on this SHA so vertex is no longer collected in pipecat tool smoke
Type
✅ Test
Changes
Branched cleanly off
litellm_internal_staging(does not re-open the #32744 history)Drop
vertex_aifromPROVIDER_PARAMSintest_realtime_pipecat_e2e.py. Pipecat tool smoke keeps openai, azure, and gemini. Vertex realtime stays covered by unit transform tests plus raw-wstest_text_conversation/test_tool_call_round_trip. Documented inREALTIME_COVERAGE_MATRIX.mdRemove Playwright
test_key_models_dropdown_e2e.pyso stage is not blocked by that UI suite