test: allow /v1/messages in supported_endpoints schema - #32742
Draft
cursor[bot] wants to merge 1 commit into
Draft
test: allow /v1/messages in supported_endpoints schema#32742cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
The muse-spark-1.1 model (added in #32701) declares /v1/messages in its supported_endpoints, but the JSON-schema enum in test_aaamodel_prices_and_context_window_json_is_valid was not updated, so the misc test shard fails on every PR based on litellm_internal_staging. Add /v1/messages (a first-class LiteLLM endpoint used by the Anthropic Messages surface) to the enum. Co-authored-by: Krrish Dholakia <krrish-berri-2@users.noreply.github.com>
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issues
Linear ticket
Pre-Submission checklist
@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
Before the fix,
misc / Run testsfails on every PR based onlitellm_internal_stagingwith:Example failure: https://github.com/BerriAI/litellm/actions/runs/29074129118/job/86301878406
Local reproduction of just the schema validation, at commit
6318c7ee3c(with the enum patch applied):Without the patch the same script raises the same
ValidationErrorseen in CI.Type
✅ Test
Changes
meta/muse-spark-1.1(added in #32701) legitimately declares/v1/messagesundersupported_endpointsbecause LiteLLM routes that model through its Anthropic Messages transformation, but the JSON-schema enum intest_aaamodel_prices_and_context_window_json_is_validwas never updated, so themisc / Run testsshard fails on every open PR rebased ontolitellm_internal_staging. Added/v1/messagesto the enum;/v1/messagesis already a first-class LiteLLM endpoint (litellm/main.py,litellm/utils.py, tencent + openai_likemessages/transformation.py, proxy pre-call utils, etc.), so no other data or code changes are needed.