Skip to content

ci: run unit test workflows on ui-only changes (revert #32422) - #32530

Merged
yuneng-berri merged 2 commits into
litellm_internal_stagingfrom
litellm_/competent-williams-410458
Jul 8, 2026
Merged

ci: run unit test workflows on ui-only changes (revert #32422)#32530
yuneng-berri merged 2 commits into
litellm_internal_stagingfrom
litellm_/competent-williams-410458

Conversation

@yuneng-berri

Copy link
Copy Markdown
Contributor

Relevant issues

Reverts #32422

Linear ticket

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have added meaningful tests (N/A; this reverts a GitHub Actions trigger filter, which has no unit-test surface. Proof is the workflow config diff below)
  • My PR passes all CI/CD checks (e.g., lint, format, unit tests)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review (Greptile reviews automatically once the PR is opened; only comment @greptileai to re-request a review after pushing changes)

Delays in PR merge?

If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).

Screenshots / Proof of Fix

This is a revert of a GitHub Actions trigger-filter change, so there is no proxy or LLM surface to exercise; the meaningful proof is the workflow trigger config before and after, plus confirmation that the paths-ignore block is gone from all 12 files

Before this revert, every test-unit-*.yml had a paths-ignore that suppressed the job on UI-only or markdown-only PRs, so a change touching only ui/litellm-dashboard/ (for example #32502) never ran "All Other Providers / Run tests", proxy-auth "Run tests", and the rest of the test-unit jobs

Trigger block after the revert (representative, test-unit-proxy-auth.yml):

on:
  pull_request:
    branches:
      - main
      - litellm_internal_staging
      - litellm_oss_staging
      - "litellm_**"

Verification that the block is removed from all 12 workflows (captured at b76073e):

$ git grep -n "paths-ignore" .github/workflows/test-unit-*.yml
no matches (paths-ignore fully removed)

Once merged, a UI-only PR will again match the pull_request trigger on these workflows and run the unit test jobs

Type

🚄 Infrastructure

Changes

Reverts #32422, which added an identical four-line paths-ignore block (ui/**, **.md, **.mdx) to the pull_request trigger of all 12 test-unit-*.yml workflows. That filter meant UI-only and docs-only PRs skipped the backend unit test suites entirely, which we do not want since UI-only changes can still interact with proxy behavior and should be gated by these jobs. This removes the paths-ignore block from all 12 files and leaves the branches: list and everything else untouched, so the unit test workflows run again on UI-only changes

@yuneng-berri
yuneng-berri requested a review from a team July 8, 2026 18:58
@greptile-apps

greptile-apps Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR reverts #32422, which had added identical paths-ignore blocks (ui/**, **.md, **.mdx) to all 12 test-unit-*.yml workflows. The revert ensures unit test suites run again on UI-only and docs-only pull requests.

  • Removes the four-line paths-ignore block from each of the 12 test-unit-*.yml workflows, leaving branch filters and all other trigger configuration unchanged.
  • No application code is touched; the only effect is that GitHub Actions will no longer skip backend unit tests when a PR only modifies dashboard UI or markdown files.

Confidence Score: 5/5

Safe to merge — the change is a mechanical removal of trigger filters from CI config with no impact on production code.

All 12 files receive exactly the same four-line deletion with no other modifications. The change is consistent, matches the stated intent (reverting #32422), and carries no risk of breaking builds or runtime behavior.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/test-unit-core-utils.yml Removes paths-ignore block so the workflow runs on UI-only and docs-only PRs again.
.github/workflows/test-unit-documentation.yml Removes paths-ignore block; identical change to the other 11 workflow files.
.github/workflows/test-unit-proxy-db.yml Removes paths-ignore block; note this file only targets main and litellm_internal_staging branches, unlike the other 11 files which also include litellm_oss_staging and litellm_** — this branch-list difference is pre-existing and not introduced by this PR.
.github/workflows/test-unit-proxy-auth.yml Removes paths-ignore block; identical change to the other 11 workflow files.
.github/workflows/test-unit-llm-providers.yml Removes paths-ignore block; identical change to the other 11 workflow files.
.github/workflows/test-unit-proxy-endpoints.yml Removes paths-ignore block; also has a workflow_dispatch trigger which is unaffected.

Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/lit..." | Re-trigger Greptile

@mateo-berri mateo-berri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks for the revert. LGTM

@yuneng-berri
yuneng-berri enabled auto-merge July 8, 2026 19:01
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@yuneng-berri
yuneng-berri merged commit b00877c into litellm_internal_staging Jul 8, 2026
124 checks passed
@yuneng-berri
yuneng-berri deleted the litellm_/competent-williams-410458 branch July 8, 2026 19:09
@codspeed-hq

codspeed-hq Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 30 untouched benchmarks


Comparing litellm_/competent-williams-410458 (b76073e) with litellm_internal_staging (86a9871)1

Open in CodSpeed

Footnotes

  1. No successful run was found on litellm_internal_staging (b76073e) during the generation of this report, so 86a9871 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants