ci: run unit test workflows on ui-only changes (revert #32422) - #32530
Conversation
…itellm_/competent-williams-410458
Greptile SummaryThis PR reverts #32422, which had added identical
Confidence Score: 5/5Safe to merge — the change is a mechanical removal of trigger filters from CI config with no impact on production code. All 12 files receive exactly the same four-line deletion with no other modifications. The change is consistent, matches the stated intent (reverting #32422), and carries no risk of breaking builds or runtime behavior. No files require special attention.
|
| Filename | Overview |
|---|---|
| .github/workflows/test-unit-core-utils.yml | Removes paths-ignore block so the workflow runs on UI-only and docs-only PRs again. |
| .github/workflows/test-unit-documentation.yml | Removes paths-ignore block; identical change to the other 11 workflow files. |
| .github/workflows/test-unit-proxy-db.yml | Removes paths-ignore block; note this file only targets main and litellm_internal_staging branches, unlike the other 11 files which also include litellm_oss_staging and litellm_** — this branch-list difference is pre-existing and not introduced by this PR. |
| .github/workflows/test-unit-proxy-auth.yml | Removes paths-ignore block; identical change to the other 11 workflow files. |
| .github/workflows/test-unit-llm-providers.yml | Removes paths-ignore block; identical change to the other 11 workflow files. |
| .github/workflows/test-unit-proxy-endpoints.yml | Removes paths-ignore block; also has a workflow_dispatch trigger which is unaffected. |
Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/lit..." | Re-trigger Greptile
mateo-berri
left a comment
There was a problem hiding this comment.
Oops. Thanks for the revert. LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Relevant issues
Reverts #32422
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
This is a revert of a GitHub Actions trigger-filter change, so there is no proxy or LLM surface to exercise; the meaningful proof is the workflow trigger config before and after, plus confirmation that the
paths-ignoreblock is gone from all 12 filesBefore this revert, every
test-unit-*.ymlhad apaths-ignorethat suppressed the job on UI-only or markdown-only PRs, so a change touching onlyui/litellm-dashboard/(for example #32502) never ran "All Other Providers / Run tests", proxy-auth "Run tests", and the rest of the test-unit jobsTrigger block after the revert (representative,
test-unit-proxy-auth.yml):Verification that the block is removed from all 12 workflows (captured at
b76073e):Once merged, a UI-only PR will again match the
pull_requesttrigger on these workflows and run the unit test jobsType
🚄 Infrastructure
Changes
Reverts #32422, which added an identical four-line
paths-ignoreblock (ui/**,**.md,**.mdx) to thepull_requesttrigger of all 12test-unit-*.ymlworkflows. That filter meant UI-only and docs-only PRs skipped the backend unit test suites entirely, which we do not want since UI-only changes can still interact with proxy behavior and should be gated by these jobs. This removes thepaths-ignoreblock from all 12 files and leaves thebranches:list and everything else untouched, so the unit test workflows run again on UI-only changes