ci: add OSS daily branch workflow - #32514
Conversation
|
|
810ce32 to
f028f0f
Compare
Greptile SummaryThis PR adds two new CI workflows to manage a dated OSS daily branch intake flow: one creates
Confidence Score: 5/5Safe to merge — both workflows are additive CI infrastructure with no effect on existing jobs or production code paths. Both files are new workflow additions. Security practices are sound: action SHAs are pinned, persist-credentials: false is set, the date input is validated against a strict regex before being embedded in a branch name, and the GITHUB_TOKEN is passed via env rather than inline expression. The blocked-files regex covers workflows, composite actions, dependency manifests, lockfiles, and common tool configs. The base-ref diffing logic correctly uses three-dot syntax to isolate the OSS delta from main/staging drift. The only notable gap is that oss-safe-checks runs concurrently with sensitive-file-guard rather than after it, which wastes runner minutes on already-blocked PRs but has no correctness impact. .github/workflows/oss_daily_guardrails.yml — the job ordering between sensitive-file-guard and oss-safe-checks is worth a second look.
|
| Filename | Overview |
|---|---|
| .github/workflows/create_daily_oss_branch.yml | New workflow creating dated OSS daily branches from main on a weekday cron or manual dispatch; uses pinned SHA, persist-credentials: false, input validation, and idempotent branch guard. |
| .github/workflows/oss_daily_guardrails.yml | New guardrails workflow blocking sensitive file changes on OSS daily branches; oss-safe-checks runs concurrently with sensitive-file-guard instead of depending on it, so the expensive test/lint job still runs even when the guard fails. |
Reviews (2): Last reviewed commit: "ci: add OSS daily branch workflow" | Re-trigger Greptile
|
|
||
| on: | ||
| schedule: | ||
| - cron: "0 16 * * 1-5" # 9am PT during daylight saving time, weekdays. |
There was a problem hiding this comment.
At 16:00 UTC this fires at 9 am PDT (UTC-7) in summer but at 8 am PST (UTC-8) in winter. The comment only documents the DST case, which can mislead reviewers into thinking the schedule is always 9 am PT. Updating it to note both seasons (or picking 17:00 UTC if 9 am year-round is the intent) would make the intent unambiguous.
| - cron: "0 16 * * 1-5" # 9am PT during daylight saving time, weekdays. | |
| - cron: "0 16 * * 1-5" # 9am PDT (UTC-7) / 8am PST (UTC-8), weekdays. Use 17:00 UTC for year-round 9am PST/PDT. |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
f028f0f to
33aaea3
Compare
|
@greptileai please review the latest head 33aaea3 |
The in-workflow regex list was hard to maintain and, because it runs on pull_request, could be modified by the same PR it inspects. Path gating for the OSS daily branches now lives in repository branch protection settings, so this workflow keeps only the OSS-safe checks: the hardcoded-secret test and ruff
56ab5e0
into
litellm_internal_staging
Relevant issues
Internal request: create a dated GitHub daily branch flow for OSS PR intake
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
YAML parse of both workflows on the updated branch:
Type
🚄 Infrastructure
Changes
Create Daily OSS Branchcreates the datedlitellm_oss_daily_YYYY_MM_DDbranch frommainon a weekday schedule or manual dispatch.OSS Daily Guardrailsruns OSS-safe checks for those branches, namely the hardcoded-secret test and ruff. Path-based restrictions for the OSS daily branches are handled through repository settings rather than in this workflow, so the earlier in-workflow file check has been removed