fix(proxy): wire general_settings SSRF allowlist to litellm globals by Sameerlite · Pull Request #32243 · BerriAI/litellm

Sameerlite · 2026-07-06T11:03:58Z

Summary

Wire user_url_validation, user_url_allowed_hosts, and provider_url_destination_allowed_hosts from general_settings into litellm.* globals during proxy startup
Document the three fields on ConfigGeneralSettings so they are recognized as valid general_settings keys
Fixes [Bug]: user_url_validation and user_url_allowed_hosts is not taking effect after https://github.com/BerriAI/litellm/pull/25906 #26599 — the SSRF error message already pointed admins at general_settings, but only litellm_settings was ever wired

Before

After

Note

Medium Risk
Touches SSRF enforcement configuration and runtime globals; incorrect wiring could leave stale allowlists or unexpected validation behavior, though the change is intended to make documented admin settings effective.

Overview
Fixes #26599 by making proxy general_settings actually drive the SSRF globals that validate_url() / safe_get already read (litellm.user_url_validation, user_url_allowed_hosts, provider_url_destination_allowed_hosts).

Adds _apply_ssrf_general_settings (with string/"false" handling for user_url_validation and explicit updates when keys are present, including null to clear allowlists) and calls it on initial config load, merged general_settings updates, and update_config_general_settings so YAML and dashboard changes take effect without restart. Documents the three fields on ConfigGeneralSettings and extends the dashboard OpenAPI schema; regression tests cover load and live config updates.

^{Reviewed by Cursor Bugbot for commit 92722db. Bugbot is set up for automated code reviews on this repo. Configure here.}

general_settings.user_url_allowed_hosts was documented in SSRF errors but never applied at startup, so internal MCP/OpenAPI URLs stayed blocked. Co-authored-by: Cursor <cursoragent@cursor.com>

greptile-apps · 2026-07-06T11:06:11Z

Greptile Summary

This PR fixes a long-standing misconfiguration gap (issue #26599) where user_url_validation, user_url_allowed_hosts, and provider_url_destination_allowed_hosts could be declared under general_settings but were never wired into the litellm.* globals that the SSRF guard actually reads.

Adds _apply_ssrf_general_settings() and calls it in all three code paths that process general_settings: YAML startup (load_config), periodic DB overlay merge (_update_general_settings), and dashboard live update (update_config_general_settings).
Documents the three fields on ConfigGeneralSettings (Pydantic) and the OpenAPI TypeScript schema so they are recognized as valid keys at both parse time and in the UI.
Includes regression tests covering YAML load, null/string coercion, and live dashboard updates; all tests use mocks with no real network calls.

Confidence Score: 5/5

The change is safe to merge — it makes previously-inert admin config keys actually take effect without altering any existing behavior for deployments that never set those keys.

The wiring is straightforward: one helper function called in three well-defined config paths, each covered by a new mock test. The null/string-coercion edge cases are explicitly tested and behave sensibly. No existing tests are weakened, and no critical path code is touched.

No files require special attention.

Important Files Changed

Filename	Overview
litellm/proxy/proxy_server.py	Adds `_normalize_user_url_validation` and `_apply_ssrf_general_settings` helpers, then calls `_apply_ssrf_general_settings` in three places: initial config load, live DB overlay merge, and dashboard `update_config_general_settings`. Logic is correct; null handling asymmetry between allowlists (clears) and validation flag (no-op) is intentional and tested.
litellm/proxy/_types.py	Adds three new Optional fields (`user_url_validation`, `user_url_allowed_hosts`, `provider_url_destination_allowed_hosts`) to `ConfigGeneralSettings` with accurate docstrings so the YAML keys are recognized and validated by Pydantic.
tests/test_litellm/proxy/proxy_server/test_proxy_config.py	Adds a regression test confirming that SSRF fields in a YAML `general_settings` block correctly reach `litellm.*` globals after `load_config`, with proper teardown to restore originals.
tests/test_litellm/proxy/test_proxy_server.py	Adds two new tests: one covering null/string-"false" edge cases in `load_config`, another verifying that live `update_config_general_settings` calls propagate all three SSRF globals, including clearing allowlists with None. Tests use only mocks — no real network calls.
ui/litellm-dashboard/src/lib/http/schema.d.ts	Adds the three new SSRF fields to the `ConfigGeneralSettings` OpenAPI schema component so the dashboard TypeScript client reflects the updated API shape.

_{Reviews (3): Last reviewed commit: "fix: clear ssrf allowlists from null set..." | Re-trigger Greptile}

codecov · 2026-07-06T11:15:02Z

Codecov Report

❌ Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
litellm/proxy/proxy_server.py	64.00%	9 Missing ⚠️

📢 Thoughts on this report? Let us know!

Use list[str] in ConfigGeneralSettings and run gen:api so schema.d.ts matches the new SSRF general_settings fields. Co-authored-by: Cursor <cursoragent@cursor.com>

mateo-berri · 2026-07-06T17:40:34Z

@greptileai

mateo-berri · 2026-07-06T17:40:41Z

@coderabbitai review

mateo-berri · 2026-07-06T17:40:44Z

bugbot run

coderabbitai · 2026-07-06T17:40:47Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

mateo-berri · 2026-07-06T17:41:12Z

(note: @Sameerlite I'm just testing out coderabbit and comparing it with bugbot. Don't treat any of the issues it comes up with as blocking for now)

coderabbitai · 2026-07-06T17:47:26Z

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch litellm_fix-general-settings-url-validation

_{Comment @coderabbitai help to get the list of available commands.}

cursor

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Autofix Details

Bugbot Autofix prepared fixes for both issues found in the latest run.

✅ Fixed: Null validation disables SSRF guard
- Null user_url_validation values are ignored and string booleans are normalized before updating the SSRF validation global.
✅ Fixed: Dashboard updates skip litellm globals
- Dashboard and DB general-settings updates now immediately apply the SSRF allowlist and validation globals used at request time.

_{You can send follow-ups to the cloud agent here.}

CLAassistant · 2026-07-06T18:08:28Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Sameerlite
❌ cursoragent
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Sameerlite · 2026-07-07T03:57:00Z

bugbot run

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Null allowlists skip global reset
- Updated SSRF settings application to assign allowlist globals whenever their config keys are present, including explicit null values, with regression coverage for load and update paths.

_{You can send follow-ups to the cloud agent here.}

Sameerlite · 2026-07-07T04:30:18Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 92722db. Configure here.}

Sameerlite · 2026-07-07T04:35:26Z

@greptileai

mateo-berri

LGTM; thanks!

fix(proxy): wire general_settings SSRF allowlist to litellm globals

c668c7e

general_settings.user_url_allowed_hosts was documented in SSRF errors but never applied at startup, so internal MCP/OpenAPI URLs stayed blocked. Co-authored-by: Cursor <cursoragent@cursor.com>

fix(proxy): regenerate dashboard types and satisfy ruff UP006 budget

a26dc86

Use list[str] in ConfigGeneralSettings and run gen:api so schema.d.ts matches the new SSRF general_settings fields. Co-authored-by: Cursor <cursoragent@cursor.com>

cursor Bot reviewed Jul 6, 2026

View reviewed changes

Comment thread litellm/proxy/proxy_server.py Outdated

Comment thread litellm/proxy/_types.py

fix: normalize ssrf general settings

c531dd6

cursor Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread litellm/proxy/proxy_server.py Outdated

fix: clear ssrf allowlists from null settings

92722db

cursor Bot reviewed Jul 7, 2026

View reviewed changes

Sameerlite requested a review from mateo-berri July 7, 2026 08:08

mateo-berri approved these changes Jul 7, 2026

View reviewed changes

Sameerlite merged commit 42f5b0b into litellm_internal_staging Jul 7, 2026
126 checks passed

Sameerlite deleted the litellm_fix-general-settings-url-validation branch July 7, 2026 15:19

Mattchewone mentioned this pull request Jul 20, 2026

chore: sync upstream v1.93.0 bitovi/litellm#14

Merged

Uh oh!

Uh oh!

Conversation

Sameerlite commented Jul 6, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

greptile-apps Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

codecov Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mateo-berri commented Jul 6, 2026

Uh oh!

mateo-berri commented Jul 6, 2026

Uh oh!

mateo-berri commented Jul 6, 2026

Uh oh!

coderabbitai Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mateo-berri commented Jul 6, 2026

Uh oh!

coderabbitai Bot commented Jul 6, 2026

Review failed

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

CLAassistant commented Jul 6, 2026

Uh oh!

Sameerlite commented Jul 7, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Sameerlite commented Jul 7, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Sameerlite commented Jul 7, 2026

Uh oh!

mateo-berri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sameerlite commented Jul 6, 2026 •

edited by cursor Bot

Loading

greptile-apps Bot commented Jul 6, 2026 •

edited

Loading

codecov Bot commented Jul 6, 2026 •

edited

Loading

coderabbitai Bot commented Jul 6, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading