Skip to content

refactor(helm): move litellm-helm chart to helm/ and drop deploy folder - #32234

Merged
yassin-berriai merged 3 commits into
litellm_internal_stagingfrom
litellm_move_helm_chart
Jul 7, 2026
Merged

refactor(helm): move litellm-helm chart to helm/ and drop deploy folder#32234
yassin-berriai merged 3 commits into
litellm_internal_stagingfrom
litellm_move_helm_chart

Conversation

@yassin-berriai

@yassin-berriai yassin-berriai commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Relevant issues

Linear ticket

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have added meaningful tests
  • My PR passes all CI/CD checks (e.g., lint, format, unit tests)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have requested a Greptile review by commenting @greptileai and received a Confidence Score of at least 4/5 before requesting a maintainer review

Delays in PR merge?

If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).

Screenshots / Proof of Fix

Both charts lint and the full helm-unittest suite passes from the new location:

$ helm lint ./helm/litellm-helm
==> Linting ./helm/litellm-helm
[INFO] Chart.yaml: icon is recommended
1 chart(s) linted, 0 chart(s) failed

$ helm lint ./helm/litellm
==> Linting ./helm/litellm
[INFO] Chart.yaml: icon is recommended
1 chart(s) linted, 0 chart(s) failed

$ helm unittest -f 'tests/*.yaml' helm/litellm-helm
 PASS  Deployment Command, Args, and Labels Tests
 PASS  Deployment Tests
 PASS  HPA Tests
 PASS  Ingress Tests
 PASS  MasterKey Secret Tests
 PASS  Migrations Job Tests
 PASS  PodDisruptionBudget Tests
 PASS  Service Configuration Tests

Charts:      1 passed, 1 total
Test Suites: 8 passed, 8 total
Tests:       54 passed, 54 total

The "Helm unit test" GitHub Actions workflow and the CircleCI helm_chart_testing job (helm lint + kind install + helm test) run on this PR itself against the new path, which is the end-to-end proof for a chart relocation

Type

🧹 Refactoring

Changes

The repo had two helm charts in two unrelated places: the classic monolithic chart at deploy/charts/litellm-helm and the newer componentized chart at helm/litellm. This PR consolidates them under a single helm/ directory, with each chart in a folder matching its chart name: helm/litellm-helm (moved, git history preserved via rename) and helm/litellm (untouched)

The chart itself is unchanged; its name stays litellm-helm since it is published under that name to the same OCI registry as the litellm image, so installs via oci://ghcr.io/berriai/litellm-helm are unaffected. The deploy/charts/ intermediate wrapper held exactly one chart and is gone

All references to the old path are updated: the helm unittest GitHub workflow, the test-unit-helm Makefile target, and the CircleCI helm_chart_testing job. The .gitignore entries for packaged charts pointed at deploy/charts/litellm/*, a directory that no longer existed; the *.tgz entries now point at the new location, and the dead charts/* entry is dropped entirely since the vendored dependency tarballs under helm/litellm-helm/charts/ are committed on purpose (pinned by Chart.lock) and ignoring them would hide future helm dep update output

With the chart moved, the only thing left in deploy/ was deploy/azure_resource_manager (an Azure Marketplace zip and bicep template from May 2024). Nothing in the repo references it, so the whole deploy/ folder is removed

@yassin-berriai
yassin-berriai requested a review from a team July 6, 2026 08:36
@yassin-berriai

Copy link
Copy Markdown
Contributor Author

@greptileai

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@greptile-apps

greptile-apps Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR consolidates the two Helm charts from separate locations (deploy/charts/litellm-helm and helm/litellm) into a single helm/ directory, and removes the now-empty deploy/ folder (including some unreferenced Azure Marketplace assets).

  • Chart relocation: deploy/charts/litellm-helm is moved to helm/litellm-helm with git history preserved; the chart name, version, and OCI registry reference are untouched.
  • Reference updates: All CI/CD consumers (CircleCI helm_chart_testing job, GitHub Actions helm_unit_test workflow, and the test-unit-helm Makefile target) are updated to the new path.
  • .gitignore cleanup: Stale deploy/charts/ patterns are replaced with helm/litellm-helm/*.tgz and helm/*.tgz; the charts/* wildcard is intentionally dropped so the committed, pinned vendored tarballs remain trackable.

Confidence Score: 5/5

Pure path relocation with no chart content changes; all CI/CD references are updated and a grep across the repo confirms no stale deploy/charts paths remain.

Every reference to the old path has been updated, the chart itself is byte-for-byte identical to what was previously under deploy/charts/litellm-helm, and both lint and helm-unittest pass at the new location per the PR screenshots.

No files require special attention.

Important Files Changed

Filename Overview
.circleci/config.yml Updated helm chart path from deploy/charts/litellm-helm to helm/litellm-helm in lint and install steps; straightforward mechanical update.
.github/workflows/helm_unit_test.yml Single-line path update for helm unittest command to point to new helm/litellm-helm location; no logic changes.
.gitignore Replaced three stale deploy/charts/ patterns with helm/litellm-helm/*.tgz and helm/*.tgz; intentionally omits helm/litellm-helm/charts/* so committed vendored tarballs remain tracked.
Makefile Updated test-unit-helm target to point to helm/litellm-helm; no other changes.
helm/litellm-helm/Chart.yaml Chart moved from deploy/charts/litellm-helm; chart name, version, and OCI registry annotations are unchanged.
helm/litellm-helm/values.yaml Values file relocated unchanged from the old deploy/charts/litellm-helm path.

Reviews (5): Last reviewed commit: "chore(gitignore): drop ignore on vendore..." | Re-trigger Greptile

@greptile-apps

greptile-apps Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR consolidates the two Helm charts previously scattered across deploy/charts/litellm-helm and helm/litellm under a single helm/ top-level directory, and removes the now-empty deploy/ folder (including an unreferenced Azure Marketplace artifact). All CI/CD references (CircleCI, GitHub Actions, Makefile) are updated to the new path.

  • deploy/charts/litellm-helm is renamed to helm/litellm-helm with git history preserved; chart name, version, and OCI registry coordinates are unchanged.
  • .gitignore patterns are updated from the old (and partially incorrect) deploy/charts/litellm/… paths to the correct helm/litellm-helm/… paths.
  • The deploy/azure_resource_manager directory (Azure Marketplace zip and bicep template, unreferenced since May 2024) is deleted as part of clearing the now-empty deploy/ tree.

Confidence Score: 4/5

A clean chart relocation with no logic changes; the only wrinkle is a gitignore/tracked-file inconsistency that could surprise a future contributor running helm dep update.

The diff is a mechanical path rename across CI/CD configs, the Makefile, and .gitignore, with the chart contents completely unchanged. Every reference to the old deploy/charts/litellm-helm path has been replaced and no stale references remain. The one thing worth attention: the .gitignore now ignores helm/litellm-helm/charts/* while the two chart archives (postgresql, redis tgz) in that directory are committed and tracked — a pattern that could silently swallow a future helm dep update without git add -f.

.gitignore — the interaction between the new helm/litellm-helm/charts/* ignore rule and the already-tracked chart archives deserves a second look.

Important Files Changed

Filename Overview
.circleci/config.yml Updated helm chart path references from deploy/charts/litellm-helm to helm/litellm-helm in lint and install commands.
.github/workflows/helm_unit_test.yml Updated helm unittest command path from deploy/charts/litellm-helm to helm/litellm-helm.
.gitignore Updated ignore patterns from deploy/charts/litellm/* to helm/litellm-helm/*; the chart archives (postgresql, redis tgz) are committed/tracked in this PR but are now also gitignored, creating a subtle mismatch for future dependency updates.
Makefile Updated test-unit-helm target path to helm/litellm-helm.
helm/litellm-helm/Chart.yaml Chart moved from deploy/charts/litellm-helm; contents unchanged, chart name and version preserved.
helm/litellm-helm/values.yaml Values file moved from deploy/charts/litellm-helm; contents unchanged.

Reviews (1): Last reviewed commit: "refactor(helm): move litellm-helm chart ..." | Re-trigger Greptile

Comment thread .gitignore
Comment thread .gitignore Outdated
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@yassin-berriai

Copy link
Copy Markdown
Contributor Author

@greptileai

@yassin-berriai

Copy link
Copy Markdown
Contributor Author

@greptileai the gitignore/tracked-file inconsistency is addressed in 0d2dc33; please review the latest commit

@yassin-berriai

Copy link
Copy Markdown
Contributor Author

@greptileai

…itellm_move_helm_chart

# Conflicts:
#	.github/workflows/helm_unit_test.yml
@yassin-berriai
yassin-berriai enabled auto-merge (squash) July 7, 2026 12:18
@yassin-berriai
yassin-berriai merged commit 3c5ae3d into litellm_internal_staging Jul 7, 2026
122 of 123 checks passed
@yassin-berriai
yassin-berriai deleted the litellm_move_helm_chart branch July 7, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants