refactor(helm): move litellm-helm chart to helm/ and drop deploy folder - #32234
Conversation
|
|
Greptile SummaryThis PR consolidates the two Helm charts from separate locations (
Confidence Score: 5/5Pure path relocation with no chart content changes; all CI/CD references are updated and a grep across the repo confirms no stale Every reference to the old path has been updated, the chart itself is byte-for-byte identical to what was previously under No files require special attention.
|
| Filename | Overview |
|---|---|
| .circleci/config.yml | Updated helm chart path from deploy/charts/litellm-helm to helm/litellm-helm in lint and install steps; straightforward mechanical update. |
| .github/workflows/helm_unit_test.yml | Single-line path update for helm unittest command to point to new helm/litellm-helm location; no logic changes. |
| .gitignore | Replaced three stale deploy/charts/ patterns with helm/litellm-helm/*.tgz and helm/*.tgz; intentionally omits helm/litellm-helm/charts/* so committed vendored tarballs remain tracked. |
| Makefile | Updated test-unit-helm target to point to helm/litellm-helm; no other changes. |
| helm/litellm-helm/Chart.yaml | Chart moved from deploy/charts/litellm-helm; chart name, version, and OCI registry annotations are unchanged. |
| helm/litellm-helm/values.yaml | Values file relocated unchanged from the old deploy/charts/litellm-helm path. |
Reviews (5): Last reviewed commit: "chore(gitignore): drop ignore on vendore..." | Re-trigger Greptile
Greptile SummaryThis PR consolidates the two Helm charts previously scattered across
Confidence Score: 4/5A clean chart relocation with no logic changes; the only wrinkle is a gitignore/tracked-file inconsistency that could surprise a future contributor running The diff is a mechanical path rename across CI/CD configs, the Makefile, and
|
| Filename | Overview |
|---|---|
| .circleci/config.yml | Updated helm chart path references from deploy/charts/litellm-helm to helm/litellm-helm in lint and install commands. |
| .github/workflows/helm_unit_test.yml | Updated helm unittest command path from deploy/charts/litellm-helm to helm/litellm-helm. |
| .gitignore | Updated ignore patterns from deploy/charts/litellm/* to helm/litellm-helm/*; the chart archives (postgresql, redis tgz) are committed/tracked in this PR but are now also gitignored, creating a subtle mismatch for future dependency updates. |
| Makefile | Updated test-unit-helm target path to helm/litellm-helm. |
| helm/litellm-helm/Chart.yaml | Chart moved from deploy/charts/litellm-helm; contents unchanged, chart name and version preserved. |
| helm/litellm-helm/values.yaml | Values file moved from deploy/charts/litellm-helm; contents unchanged. |
Reviews (1): Last reviewed commit: "refactor(helm): move litellm-helm chart ..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@greptileai the gitignore/tracked-file inconsistency is addressed in 0d2dc33; please review the latest commit |
…itellm_move_helm_chart # Conflicts: # .github/workflows/helm_unit_test.yml
3c5ae3d
into
litellm_internal_staging
Relevant issues
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
@greptileaiand received a Confidence Score of at least 4/5 before requesting a maintainer reviewDelays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
Both charts lint and the full helm-unittest suite passes from the new location:
The "Helm unit test" GitHub Actions workflow and the CircleCI
helm_chart_testingjob (helm lint + kind install + helm test) run on this PR itself against the new path, which is the end-to-end proof for a chart relocationType
🧹 Refactoring
Changes
The repo had two helm charts in two unrelated places: the classic monolithic chart at
deploy/charts/litellm-helmand the newer componentized chart athelm/litellm. This PR consolidates them under a singlehelm/directory, with each chart in a folder matching its chart name:helm/litellm-helm(moved, git history preserved via rename) andhelm/litellm(untouched)The chart itself is unchanged; its name stays
litellm-helmsince it is published under that name to the same OCI registry as thelitellmimage, so installs viaoci://ghcr.io/berriai/litellm-helmare unaffected. Thedeploy/charts/intermediate wrapper held exactly one chart and is goneAll references to the old path are updated: the helm unittest GitHub workflow, the
test-unit-helmMakefile target, and the CircleCIhelm_chart_testingjob. The.gitignoreentries for packaged charts pointed atdeploy/charts/litellm/*, a directory that no longer existed; the*.tgzentries now point at the new location, and the deadcharts/*entry is dropped entirely since the vendored dependency tarballs underhelm/litellm-helm/charts/are committed on purpose (pinned byChart.lock) and ignoring them would hide futurehelm dep updateoutputWith the chart moved, the only thing left in
deploy/wasdeploy/azure_resource_manager(an Azure Marketplace zip and bicep template from May 2024). Nothing in the repo references it, so the wholedeploy/folder is removed