Skip to content

fix(scripts): resolve worktree root before relative_to in type_check_gate #31906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuneng-berri merged 2 commits into from
Jul 1, 2026
Merged

fix(scripts): resolve worktree root before relative_to in type_check_gate #31906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9888ff
fix(scripts): resolve worktree root before relative_to in type_check_…
yuneng-berri Jul 1, 2026
3c46618
Merge remote-tracking branch 'origin/litellm_internal_staging' into l…
yuneng-berri Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/type_check_gate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def _to_relative(raw: str, root: Path) -> str | None:
path = Path(raw)
absolute = path if path.is_absolute() else root / path
try:
return absolute.resolve().relative_to(root).as_posix()
return absolute.resolve().relative_to(root.resolve()).as_posix()
except ValueError:
return None

Expand Down
15 changes: 15 additions & 0 deletions tests/test_litellm/test_type_check_gate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,21 @@ def test_paths_outside_repo_are_skipped():
assert gate.count_basedpyright(payload) == {}


def test_symlinked_root_keeps_diagnostics_in_tree(tmp_path):
real = tmp_path / "real"
real.mkdir()
link = tmp_path / "link"
link.symlink_to(real)
payload = json.dumps(
{
"generalDiagnostics": [
_bpr(link / "litellm" / "x.py", "error", "reportArgumentType")
]
}
)
assert gate.count_basedpyright(payload, root=link) == {"reportArgumentType": 1}


def test_at_or_under_ceiling_passes():
budget = {"no-any-return": {"limit": 5}}
assert gate.evaluate({"no-any-return": 5}, {}, budget) == []
Expand Down
Loading