feat(ui): disclaim that the Update API Key modal only rotates api_key - #31805
Conversation
An adversarial review of the credential-rotation work noted the modal always writes litellm_params.api_key, so models that authenticate with an Azure AD token, AWS credentials, or a Vertex service-account JSON are not rotated by it. Adds a warning Alert to the modal so users are not misled into thinking those secrets were rotated; broadening the modal to those providers is a follow-up
Greptile SummaryThis PR adds a static informational
Confidence Score: 5/5Safe to merge — only a static warning banner is added with no changes to logic, API calls, or data flow. The change is a single informational UI element: an Ant Design Alert placed above the credential form. No logic, state, network calls, or component contracts are touched. The only minor tension is that the existing description text sounds more conclusive than the warning that immediately follows, but this is a cosmetic wording concern and does not affect functionality. No files require special attention.
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/src/components/update_model_credentials_modal.tsx | Adds an Ant Design Alert warning above the API key field to notify users that Azure AD token, AWS, and Vertex service-account JSON auth are not covered by this rotation modal. |
Reviews (1): Last reviewed commit: "feat(ui): disclaim that the Update API K..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…odal.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…BerriAI#31805) * feat(ui): disclaim that the Update API Key modal only rotates api_key An adversarial review of the credential-rotation work noted the modal always writes litellm_params.api_key, so models that authenticate with an Azure AD token, AWS credentials, or a Vertex service-account JSON are not rotated by it. Adds a warning Alert to the modal so users are not misled into thinking those secrets were rotated; broadening the modal to those providers is a follow-up * Update ui/litellm-dashboard/src/components/update_model_credentials_modal.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * style(ui): prettier-format the credential modal --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
2 participants
Relevant issues
Follow-up to #28089
Linear ticket
Summary
The Update API Key modal added in #28089 always writes
litellm_params.api_key, so it does not rotate the credential for models that authenticate a different way (Azure usingazure_ad_token, Bedrock using AWS keys, Vertex using a service-account JSON). On those models the button is still shown, and pasting a new secret there writes a strayapi_keythat the provider ignores while the real credential is left unchanged. This adds a warning so users of those providers are not misled into thinking their secret was rotatedBroadening the modal to rotate the correct field per provider is the real fix and is left as a follow-up; this is just the honest interim disclaimer
Pre-Submission checklist
@greptileaiand received a Confidence Score of at least 4/5 before requesting a maintainer reviewScreenshots / Proof of Fix
Static antd warning
Alertinside the modal. To see it: open the Admin UI at/ui/models-and-endpoints, open any DB model, click "Update API Key", and the warning renders above the New API Key field. No test added because it is a static informational element with no logicType
📖 Documentation
Changes
Adds a warning
AlerttoUpdateModelCredentialsModalnoting that onlyapi_keyis rotated and that Azure AD token / AWS / Vertex JSON providers are not covered yet