feat(proxy): audit default user settings updates

[yucheng-berri]

Relevant issues

Linear ticket

Resolves LIT-3839

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

• I have added meaningful tests
• My PR passes all CI/CD checks (e.g., lint, format, unit tests)
• My PR's scope is as isolated as possible; it only solves 1 specific problem
• I have requested a Greptile review by commenting @greptileai and received a Confidence Score of at least 4/5 before requesting a maintainer review

Screenshots / Proof of Fix

This PR closes the customer-impacting path: an admin changes Default User Settings from the dashboard and the change is recorded with who did it and what changed. The dashboard hits PATCH /update/internal_user_settings, NOT /config/update, and today that path writes nothing to LiteLLM_AuditLog.

Reproduced live against a local proxy on :4010 with store_audit_logs: true and an enterprise license, backed by a real Postgres.

Before (current behavior on litellm_internal_staging):

$ curl -X PATCH localhost:4010/update/internal_user_settings -H "Authorization: Bearer sk-1234" -H "Content-Type: application/json" \
    -d '{"max_budget":999.0,"models":["gpt-4.1-mini"]}'
{"message":"Internal user settings updated successfully","status":"success", ...}

$ psql -tAc 'SELECT count(*) FROM "LiteLLM_AuditLog";'
0    # nothing recorded

After (this PR):

$ curl -X PATCH localhost:4010/update/internal_user_settings ... \
    -d '{"max_budget":999.0,"models":["gpt-4.1-mini"]}'
{"message":"Internal user settings updated successfully","status":"success", ...}

Audit row written:

{
  "action": "updated",
  "table_name": "LiteLLM_Config",
  "object_id": "default_internal_user_params",
  "changed_by": "default_user_id",
  "changed_by_api_key": "litellm_proxy_master_key",
  "before": {"user_role":"internal_user_viewer","max_budget":100.0,"models":["gpt-3.5-turbo","gpt-4"]},
  "after":  {"user_role":"internal_user_viewer","max_budget":999.0,"models":["gpt-4.1-mini"]}
}

changed_by records the acting user and changed_by_api_key records the key hash, so a UI/SSO admin edit (session token) is distinguishable from a direct API call (master or virtual key).

Type

🆕 New Feature

Changes

Adds audit logging for the customer-impacting path: PATCH /update/internal_user_settings. The dashboard's Default User Settings page hits this route, and there is no record today of who changed what.

Introduces the small framework that future system-wide settings audits will share: a LitellmTableNames.CONFIG_TABLE_NAME enum value, a create_config_audit_log helper that reuses the existing create_object_audit_log path (so store_audit_logs and the enterprise gate still apply), and a _dump_redacted_config helper that strips secret leaves from the snapshots using the same matcher /config/field/info applies for non-admins. environment_variables is special-cased to redact every value, since it carries credentials under non-secret-looking uppercase keys (e.g. DATABASE_URL).

Only update_internal_user_settings is wired up in this change. Coverage for the other LiteLLM_Config writers (the generic /config/* endpoints, default_team_settings, mcp_semantic_filter, allowed-IP add/delete, sso_settings, ui_theme_settings, ui_settings) is the follow-up so each can be verified live against the credential-bearing fields it actually carries. The follow-up is open against this branch as the broader-scope PR.

The audit-actor parameter on _update_litellm_setting is optional in this PR so non-audited callers keep working unchanged; the follow-up will make it required once every caller is wired up.

---

Note

Medium Risk
Touches proxy config persistence and audit storage with credential redaction logic; scope is narrow (one UI route) and audit is fire-and-forget after commit.

Overview
Dashboard Default User Settings changes via PATCH /update/internal_user_settings now write LiteLLM_AuditLog rows (table LiteLLM_Config, object id default_internal_user_params) with actor, before/after snapshots, and existing store_audit_logs / enterprise gating.

Adds shared helpers: create_config_audit_log (via create_object_audit_log), _dump_redacted_config (secret-key redaction aligned with /config/field/info; environment_variables values fully redacted), and LitellmTableNames.CONFIG_TABLE_NAME. _update_litellm_setting accepts an optional admin actor and schedules audit writes after save_config so audit failures cannot 500 the request.

Only update_internal_user_settings is wired in this PR; other config writers remain for follow-up. Tests cover redaction, audit row shape, disabled audit logs, and 200 on audit failure.

^{Reviewed by Cursor Bugbot for commit 6e5053f. Bugbot is set up for automated code reviews on this repo. Configure here.}

[yucheng-berri]

@greptileai

[codspeed-hq]

Merging this PR will not alter performance

✅ 30 untouched benchmarks

---

_{Comparing litellm_lit_3839_default_user_settings_audit (24068f8) with litellm_internal_staging (8beb68a)}

[greptile-apps]

Greptile Summary

This PR closes the audit gap for PATCH /update/internal_user_settings: the dashboard path that writes Default User Settings previously committed config with no LiteLLM_AuditLog row. It introduces LitellmTableNames.CONFIG_TABLE_NAME, a _dump_redacted_config helper (with default=str for YAML-loaded values), and a create_config_audit_log function wired into _update_litellm_setting via asyncio.create_task so audit failures never block a successful save.

• Adds _dump_redacted_config that redacts secret-named leaves (via the existing _redact_secret_values_in_obj matcher) and fully redacts all values for environment_variables; the previously flagged dead non-dict branch that would have emitted a bare "REDACTED" string (crashing the audit-log constructor) has been removed.
• Threads an optional user_api_key_dict through _update_litellm_setting; the audit row is only written when an actor is provided, keeping existing callers unchanged until they are individually wired up.
• New unit and integration tests cover: secret redaction, datetime/non-JSON-native values via default=str, the store_audit_logs=False no-op path, full field assertions on the written audit row, and the fire-and-forget 200-on-failure contract.

Confidence Score: 5/5

All three previously raised issues have been addressed: the blocking audit await is now fire-and-forget via asyncio.create_task, json.dumps uses default=str throughout, and the dead non-dict redact_all_values branch that would have written a bare REDACTED string to the audit row has been removed. The change is narrowly scoped to the update_internal_user_settings path and does not touch auth or request routing.

No remaining defects in the changed code. The three prior findings are fully resolved, the helper functions are correct, and the new tests exercise the key contracts: secret redaction, YAML-native type handling, the store_audit_logs=False no-op, correct audit-row fields, and the fire-and-forget guarantee that a failing audit write never turns a successful config save into a 500.

No files require special attention.

Important Files Changed

Filename	Overview
litellm/proxy/_types.py	Adds CONFIG_TABLE_NAME = 'LiteLLM_Config' to LitellmTableNames enum — minimal, correct addition.
litellm/proxy/proxy_server.py	Adds _dump_redacted_config (with default=str for YAML-loaded non-JSON-native values) and create_config_audit_log. Dead non-dict redact_all_values branch from a prior iteration has been removed; the fallthrough to _redact_secret_values_in_obj is now the correct behavior for that unreachable path. create_object_audit_log type contract (Optional[str] before/after) is satisfied.
litellm/proxy/ui_crud_endpoints/proxy_setting_endpoints.py	Threads user_api_key_dict through _update_litellm_setting and schedules the audit write via asyncio.create_task (fire-and-forget) after save_config, so audit failures never surface as 500s. before_value is captured before any in-memory or DB update.
tests/test_litellm/proxy/test_proxy_server.py	New unit tests for _dump_redacted_config (None passthrough, secret-leaf redaction, default=str for datetime) and create_config_audit_log (audit row written with correct fields; noop when store_audit_logs=False). Deleted the prior misleading test for the non-dict redact_all_values dead branch.
tests/test_litellm/proxy/ui_crud_endpoints/test_proxy_setting_endpoints.py	Two new integration tests: one asserts the full audit row is written with correct fields (object_id, action, table_name, changed_by, before/after values) and one asserts 200 is returned even when the audit helper raises — validating the fire-and-forget contract.

_{Reviews (6): Last reviewed commit: "refactor(proxy): drop unreachable non-di..." | Re-trigger Greptile}

[codecov]

Codecov Report

❌ Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
litellm/proxy/proxy_server.py	82.75%	5 Missing ⚠️

📢 Thoughts on this report? Let us know!

[greptile-apps]

Greptile Summary

This PR adds audit logging for PATCH /update/internal_user_settings, closing a gap where dashboard-initiated Default User Settings changes were silently unrecorded in LiteLLM_AuditLog. It introduces create_config_audit_log (a thin wrapper over create_object_audit_log) and _dump_redacted_config (secret-leaf redaction before storage), wired up for the default_internal_user_params path only, with follow-up PRs planned for the other config writers.

• Adds CONFIG_TABLE_NAME = "LiteLLM_Config" to LitellmTableNames and a create_config_audit_log helper that reuses the existing enterprise audit-log gate (store_audit_logs + premium_user).
• _dump_redacted_config strips secret fields using the same name-matching logic as /config/field/info, with a full-redact bypass for environment_variables — but the bypass silently falls through to key-name matching when the value is not a dict.
• The create_config_audit_log call in _update_litellm_setting is not wrapped in try/except: an unexpected failure after save_config returns a 500 to the caller even though the setting was already committed.

Confidence Score: 3/5

The settings change itself is always committed correctly; only the audit-log write has unguarded failure modes that could surface errors to callers after the fact.

After save_config succeeds, create_config_audit_log is awaited without a try/except. Any unexpected exception there would propagate to the caller as a 500 while leaving the setting already changed in the DB. Audit logging should never block or fail the main request path.

proxy_setting_endpoints.py (unguarded audit call after save) and proxy_server.py (_dump_redacted_config fallback logic)

Important Files Changed

Filename	Overview
litellm/proxy/_types.py	Adds CONFIG_TABLE_NAME enum value to LitellmTableNames; straightforward and correct.
litellm/proxy/proxy_server.py	Adds _dump_redacted_config and create_config_audit_log helpers; _dump_redacted_config has a silent fallback when redact_all_values=True and value is not a dict.
litellm/proxy/ui_crud_endpoints/proxy_setting_endpoints.py	Wires user_api_key_dict through _update_litellm_setting; the create_config_audit_log call after save_config is not wrapped in try/except.
tests/test_litellm/proxy/test_proxy_server.py	Adds unit tests for _dump_redacted_config and create_config_audit_log using mocks only; well-structured.
tests/test_litellm/proxy/ui_crud_endpoints/test_proxy_setting_endpoints.py	Adds integration-style regression test for the audit-log write through the full endpoint; mocks only, no real network calls.

_{Reviews (2): Last reviewed commit: "feat(proxy): audit default user settings..." | Re-trigger Greptile}

[yucheng-berri]

@greptileai re-review please. Addressed all three findings on the original commit:

• Switched the audit-log call in _update_litellm_setting from blocking await to asyncio.create_task so a post-save audit failure cannot surface as a 500 to the caller. Matches the pattern in model_management_endpoints and the other create_object_audit_log call sites.
• Added default=str to both json.dumps calls in _dump_redacted_config so YAML-loaded datetime/custom values serialize cleanly, matching the sibling audit-log serializers in team_endpoints.py.
• Tightened the redact_all_values branch to redact wholesale for non-dict inputs rather than falling through to the key-name matcher.

Each fix has a mutation-checked regression test.

[yucheng-berri]

bugbot run

[yucheng-berri]

@greptileai

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 24068f8. Configure here.}

[yucheng-berri]

@greptileai please re-review the latest HEAD (24068f8). The three findings from your prior review are addressed:

• Blocking await on audit-log write -> switched to asyncio.create_task so a post-save audit failure cannot surface as a 500. Matches the create_object_audit_log pattern in model_management_endpoints.
• json.dumps without default=str -> added to both calls in _dump_redacted_config.
• redact_all_values silent fallthrough for non-dict values -> wholesale redact for non-dict inputs.

Each fix has a mutation-checked regression test.

[yucheng-berri]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 24068f8. Configure here.}

[yucheng-berri]

@greptileai please re-review HEAD 6e5053f. Addresses the code-review finding that the non-dict redact_all_values fallback in _dump_redacted_config emitted json.dumps("REDACTED"), which would crash LiteLLM_AuditLogs construction if ever hit (mask_api_keys validator calls json.loads on the already-parsed bare string). Reachability was zero (redact_all_values is only True for environment_variables which is always a dict), but the code was provably wrong. Deleted the dead branch and its misleading test.

[yucheng-berri]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 6e5053f. Configure here.}