fix(proxy): extend banned-params + admin-clear lists (VERIA-493) by yucheng-berri · Pull Request #31742 · BerriAI/litellm

yucheng-berri · 2026-06-30T19:01:59Z

Relevant issues

Linear ticket

Resolves VERIA-493

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

I have added meaningful tests
My PR passes all CI/CD checks (e.g., lint, format, unit tests)
My PR's scope is as isolated as possible; it only solves 1 specific problem
I have requested a Greptile review by commenting @greptileai and received a Confidence Score of at least 4/5 before requesting a maintainer review

Screenshots / Proof of Fix

Extends the proxy's existing banned-request-body list and admin-config clearing list, matching how analogous provider fields are already handled. Verified against a live local proxy

Type

🐛 Bug Fix

Changes

Two new entries in each of the two existing lists, next to the existing provider-specific entries. Regression tests in the existing mapped test file under tests/test_litellm/proxy/auth/. Greptile 5/5

yucheng-berri · 2026-06-30T19:02:52Z

@greptileai

codspeed-hq · 2026-06-30T19:03:33Z

Merging this PR will improve performance by 23.24%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 28 untouched benchmarks

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`test_completion_with_tools`	4.2 ms	3.2 ms	+31.39%
⚡	`test_completion_simple_message`	4.7 ms	4 ms	+15.59%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing litellm_veria_493_nvidia_riva_nvcf (019afa8) with litellm_internal_staging (a0b26d2)}

greptile-apps · 2026-06-30T19:05:54Z

Greptile Summary

This PR adds two NVIDIA Riva-specific fields (nvcf_function_id and use_ssl) to the proxy's banned-request-body list and to the admin-config-clearing list for BYOK api_base overrides, matching how analogous provider fields like the OCI signing params are already handled.

auth_utils.py: two new entries in _BANNED_REQUEST_BODY_PARAMS block client-supplied values at the proxy boundary; both existing admin escape hatches (proxy-wide flag and per-deployment configurable_clientside_auth_params) remain functional.
clientside_credential_handler.py: the same fields are added to kwargs_only_fields so admin-pinned values are stripped before forwarding to a caller-redirected upstream.
Tests cover root-level rejection, api_key co-presence regression, both opt-in paths (including a monkeypatched per-deployment path), nested-container smuggling, and clearing on api_base override.

Confidence Score: 5/5

The change is additive and consistent with the existing provider-field pattern; both admin opt-in escape hatches are preserved and well-tested.

Two fields are appended to two existing lists using the same pattern as the OCI, Bedrock, and SageMaker entries already there. All new tests are mock-only and cover both changed files including the per-deployment opt-in path. No existing tests are weakened.

No files require special attention.

Important Files Changed

Filename	Overview
litellm/proxy/auth/auth_utils.py	Adds `nvcf_function_id` and `use_ssl` to `_BANNED_REQUEST_BODY_PARAMS`, consistent with the existing provider-specific endpoint fields in the same list
litellm/router_utils/clientside_credential_handler.py	Adds the same two fields to `kwargs_only_fields` so admin-pinned values are cleared when a caller redirects `api_base`, parallel to the existing OCI entries
tests/test_litellm/proxy/auth/test_auth_utils.py	Adds two new test classes covering root-level rejection, api_key co-presence, proxy-wide opt-in, per-deployment opt-in (monkeypatched), nested smuggling, and `api_base`-override clearing for both new fields; all tests are mock-only

_{Reviews (6): Last reviewed commit: "fix(proxy): extend banned-params + admin..." | Re-trigger Greptile}

greptile-apps · 2026-06-30T19:06:05Z

Greptile Summary

This PR adds nvcf_function_id to two enforcement lists: _BANNED_REQUEST_BODY_PARAMS in auth_utils.py (blocking client-supplied values at the proxy boundary) and _admin_config_fields_to_clear_on_base_override() in clientside_credential_handler.py (dropping the admin-pinned value when a caller redirects api_base). The change mirrors the existing pattern used for aws_bedrock_project_id and the OCI provider fields, with no modifications to the enforcement logic itself.

litellm/proxy/auth/auth_utils.py: nvcf_function_id appended to _BANNED_REQUEST_BODY_PARAMS with a descriptive inline comment; both admin opt-in paths (allow_client_side_credentials and configurable_clientside_auth_params) remain available.
litellm/router_utils/clientside_credential_handler.py: nvcf_function_id added to the kwargs_only_fields list so it is cleared alongside OCI fields when api_base is caller-redirected.
Tests: Four new tests cover root-level rejection, rejection when api_key is co-present, proxy-wide opt-in, and clearing on base override; the per-deployment configurable_clientside_auth_params opt-in path is not tested for this field (consistent with the existing aws_bedrock_project_id suite).

Confidence Score: 4/5

Safe to merge; the changes are additive and narrowly scoped to two enforcement lists with no modifications to surrounding logic.

Both changes correctly follow the established pattern for banned params and admin-config clearing. The only gap is the absence of a test for the per-deployment configurable_clientside_auth_params opt-in path — consistent with the existing aws_bedrock_project_id test class but still an untested branch given that the 401 error message documents it as a valid opt-in.

The test file would benefit from a per-deployment opt-in test to match what the error message documents; no production files require special attention.

Important Files Changed

Filename	Overview
litellm/proxy/auth/auth_utils.py	Adds `nvcf_function_id` to `_BANNED_REQUEST_BODY_PARAMS`; follows the same pattern as `aws_bedrock_project_id` and other provider-specific endpoint fields. No logic changes to the enforcement code itself.
litellm/router_utils/clientside_credential_handler.py	Adds `nvcf_function_id` to the `kwargs_only_fields` list in `_admin_config_fields_to_clear_on_base_override()`, consistent with the OCI field entries immediately above it. Correctly dropped when a caller redirects `api_base`.
tests/test_litellm/proxy/auth/test_auth_utils.py	Adds four new tests covering root-level rejection, rejection when `api_key` is co-present, proxy-wide opt-in, and clearing on base override. Missing a test for the per-deployment `configurable_clientside_auth_params` opt-in path, which the error message documents as a valid opt-in.

_{Reviews (1): Last reviewed commit: "fix(proxy): block client-supplied nvcf_f..." | Re-trigger Greptile}

codecov · 2026-06-30T19:07:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

yucheng-berri · 2026-06-30T19:10:18Z

Addressed manager-review feedback. @greptileai please re-review the new head.

yucheng-berri · 2026-06-30T19:32:12Z

Addressed Greptile coverage feedback as a test-only follow-up commit. @greptileai please take another pass.

yucheng-berri · 2026-06-30T20:19:20Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 88a8e63. Configure here.}

yucheng-berri · 2026-06-30T21:17:56Z

Addressed Greptile feedback on test coverage and docstring terseness. @greptileai please re-review.

yucheng-berri · 2026-06-30T21:18:44Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 29e55ae. Configure here.}

yucheng-berri · 2026-06-30T21:28:17Z

Final CI: green. One known-flaky live-provider job at the time of comment, resolved on re-run; this PR does not touch that code path.

mateo-berri

LGTM; thanks!

non-blocking nit: is Greptile's docstring nit here legit?:

the single non-critical note is a style-level docstring cleanup in tests/test_litellm/proxy/auth/test_auth_utils.py

…(VERIA-493) Two NVIDIA-Riva-specific fields consumed by the audio-transcription handler via the provider's `optional_params` passthrough were not covered by the proxy's existing banned-request-body list or the admin-config clearing list applied on `api_base` BYOK override: * `nvcf_function_id` * `use_ssl` Add both to `_BANNED_REQUEST_BODY_PARAMS` in `litellm/proxy/auth/auth_utils.py` and to the kwargs-only list in `_admin_config_fields_to_clear_on_base_override()` in `litellm/router_utils/clientside_credential_handler.py`, next to the analogous provider-specific entries already there (`aws_bedrock_*`, OCI provider fields, etc.). Same admin opt-ins as every other entry on those lists (`general_settings.allow_client_side_credentials` proxy-wide, or `configurable_clientside_auth_params` per deployment). Regression tests in `tests/test_litellm/proxy/auth/test_auth_utils.py` cover root-level rejection, the historical `api_key` bypass, both admin opt-in paths (proxy-wide and per-deployment), nested-container smuggling via the existing recursive walk, and clearing on `api_base` override. Mutation check verified. Resolves VERIA-493

yucheng-berri · 2026-06-30T22:14:15Z

Force-pushed: squashed into a single commit with a redacted message and trimmed inline comments. Same diff content.

…(VERIA-493) (BerriAI#31742) Two NVIDIA-Riva-specific fields consumed by the audio-transcription handler via the provider's `optional_params` passthrough were not covered by the proxy's existing banned-request-body list or the admin-config clearing list applied on `api_base` BYOK override: * `nvcf_function_id` * `use_ssl` Add both to `_BANNED_REQUEST_BODY_PARAMS` in `litellm/proxy/auth/auth_utils.py` and to the kwargs-only list in `_admin_config_fields_to_clear_on_base_override()` in `litellm/router_utils/clientside_credential_handler.py`, next to the analogous provider-specific entries already there (`aws_bedrock_*`, OCI provider fields, etc.). Same admin opt-ins as every other entry on those lists (`general_settings.allow_client_side_credentials` proxy-wide, or `configurable_clientside_auth_params` per deployment). Regression tests in `tests/test_litellm/proxy/auth/test_auth_utils.py` cover root-level rejection, the historical `api_key` bypass, both admin opt-in paths (proxy-wide and per-deployment), nested-container smuggling via the existing recursive walk, and clearing on `api_base` override. Mutation check verified. Resolves VERIA-493

greptile-apps Bot reviewed Jun 30, 2026

View reviewed changes

Comment thread tests/test_litellm/proxy/auth/test_auth_utils.py Outdated

Comment thread tests/test_litellm/proxy/auth/test_auth_utils.py

greptile-apps Bot reviewed Jun 30, 2026

View reviewed changes

Comment thread tests/test_litellm/proxy/auth/test_auth_utils.py

yucheng-berri force-pushed the litellm_veria_493_nvidia_riva_nvcf branch from b9d01a6 to 83a94ab Compare June 30, 2026 19:09

cursor Bot reviewed Jun 30, 2026

View reviewed changes

mateo-berri approved these changes Jun 30, 2026

View reviewed changes

yucheng-berri force-pushed the litellm_veria_493_nvidia_riva_nvcf branch from 29e55ae to 019afa8 Compare June 30, 2026 22:14

yucheng-berri changed the title ~~fix(proxy): block client-supplied nvcf_function_id (VERIA-493)~~ fix(proxy): extend banned-params + admin-clear lists (VERIA-493) Jun 30, 2026

yucheng-berri merged commit 41f9d8d into litellm_internal_staging Jun 30, 2026
126 checks passed

yucheng-berri deleted the litellm_veria_493_nvidia_riva_nvcf branch June 30, 2026 22:30

Uh oh!

Uh oh!

Conversation

yucheng-berri commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Relevant issues

Linear ticket

Pre-Submission checklist

Screenshots / Proof of Fix

Type

Changes

Uh oh!

yucheng-berri commented Jun 30, 2026

Uh oh!

codspeed-hq Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 23.24%

Performance Changes

Uh oh!

greptile-apps Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Jun 30, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

Uh oh!

codecov Bot commented Jun 30, 2026

Codecov Report

Uh oh!

yucheng-berri commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yucheng-berri commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yucheng-berri commented Jun 30, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

yucheng-berri commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yucheng-berri commented Jun 30, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

yucheng-berri commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mateo-berri left a comment

Choose a reason for hiding this comment

Uh oh!

yucheng-berri commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yucheng-berri commented Jun 30, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 30, 2026 •

edited

Loading

greptile-apps Bot commented Jun 30, 2026 •

edited

Loading

yucheng-berri commented Jun 30, 2026 •

edited

Loading

yucheng-berri commented Jun 30, 2026 •

edited

Loading

yucheng-berri commented Jun 30, 2026 •

edited

Loading

yucheng-berri commented Jun 30, 2026 •

edited

Loading

yucheng-berri commented Jun 30, 2026 •

edited

Loading