fix(mavvrik): advance metricsMarker after successful upload - #30966
Closed
pghuge-cloudwiz wants to merge 4 commits into
Closed
fix(mavvrik): advance metricsMarker after successful upload#30966pghuge-cloudwiz wants to merge 4 commits into
pghuge-cloudwiz wants to merge 4 commits into
Conversation
Without this PATCH call the catch-up logic in MavvrikFocusLogger re-exports the same dates on every daily run.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
When "mavvrik" is in litellm.callbacks as a string, the logger is instantiated lazily on the first LLM call. init_mavvrik_focus_background_job runs at startup before any LLM call, so it found no MavvrikFocusLogger instance and silently skipped scheduling the daily export job. Fix: if no instance is found but "mavvrik" is in litellm.callbacks, call _init_custom_logger_compatible_class to force instantiation before the scheduler job is registered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #31068 which is based on the latest
litellm_internal_stagingtip with only our two fixes (no unrelated commits).