Skip to content

fix(test): drop references to removed Agent Shin workflows - #30791

Merged
ryan-crabbe-berri merged 1 commit into
litellm_internal_stagingfrom
litellm_fix_stale_triage_workflow_test
Jun 18, 2026
Merged

fix(test): drop references to removed Agent Shin workflows#30791
ryan-crabbe-berri merged 1 commit into
litellm_internal_stagingfrom
litellm_fix_stale_triage_workflow_test

Conversation

@ryan-crabbe-berri

Copy link
Copy Markdown
Contributor

Relevant issues

Linear ticket

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have added meaningful tests
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have requested a Greptile review by commenting @greptileai and received a Confidence Score of at least 4/5 before requesting a maintainer review

Screenshots / Proof of Fix

Before, on litellm_internal_staging, six cases failed because the two workflow files they parametrize over no longer exist:

$ .venv/bin/python -m pytest tests/test_litellm/test_github_triage_workflows.py -q
FAILED ...::test_llm_client_install_is_hash_pinned[review_gate.yml] - FileNotFoundError: .../.github/workflows/review_gate.yml
FAILED ...::test_llm_client_install_is_hash_pinned[triage_pr_with_llm.yml] - FileNotFoundError: .../.github/workflows/triage_pr_with_llm.yml
FAILED ...::test_should_require_agent_shin_enabled_for_close[review_gate.yml] - FileNotFoundError: ...
FAILED ...::test_should_require_agent_shin_enabled_for_close[triage_pr_with_llm.yml] - FileNotFoundError: ...
FAILED ...::test_should_use_failsafe_equals_true_comparison[review_gate.yml-CLOSE_FLAG] - FileNotFoundError: ...
FAILED ...::test_should_use_failsafe_equals_true_comparison[triage_pr_with_llm.yml-DISPATCH_CLOSE] - FileNotFoundError: ...

After:

$ .venv/bin/python -m pytest tests/test_litellm/test_github_triage_workflows.py -q
..............                                                           [100%]
14 passed in 0.23s

Type

✅ Test

Changes

#30784 removed the pull_request_target Agent Shin workflows, deleting .github/workflows/review_gate.yml and .github/workflows/triage_pr_with_llm.yml. tests/test_litellm/test_github_triage_workflows.py still named both files in DESTRUCTIVE_GATE_ENV and LLM_CLIENT_INSTALLER_WORKFLOWS, and _load_workflow reads each file with no existence guard, so every parametrized case for the two deleted workflows raised FileNotFoundError.

This drops the two stale entries from both tables. The four workflows that still exist (triage_issue_with_llm.yml, close_low_quality_prs.yml, triage_reconsider.yml, triage_rollout_heads_up.yml) keep their guardrail coverage unchanged

PR #30784 deleted .github/workflows/review_gate.yml and
triage_pr_with_llm.yml, but test_github_triage_workflows.py still
listed both in its parametrize tables, so _load_workflow raised
FileNotFoundError for every case naming them.

Remove the two stale entries from DESTRUCTIVE_GATE_ENV and
LLM_CLIENT_INSTALLER_WORKFLOWS; the remaining four workflows that still
exist keep their guardrail coverage.
@greptile-apps

greptile-apps Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes two stale entries (review_gate.yml and triage_pr_with_llm.yml) from the test parametrization tables in test_github_triage_workflows.py after those workflow files were deleted in #30784, restoring a clean test run.

  • Drops review_gate.yml and triage_pr_with_llm.yml from DESTRUCTIVE_GATE_ENV and LLM_CLIENT_INSTALLER_WORKFLOWS; every parametrized test case for those two files was raising FileNotFoundError because _load_workflow reads the file with no existence guard.
  • The four workflows that still exist (triage_issue_with_llm.yml, close_low_quality_prs.yml, triage_reconsider.yml, triage_rollout_heads_up.yml) are unchanged and keep their full guardrail coverage.

Confidence Score: 5/5

Safe to merge — removes only the two dead entries that were causing test failures after the workflow files were deleted.

The change is entirely surgical: two filename strings are removed from two lookup tables in a test file. No production code is touched, no assertions are weakened, and the four active workflows retain identical test coverage.

No files require special attention.

Important Files Changed

Filename Overview
tests/test_litellm/test_github_triage_workflows.py Removes stale references to two deleted workflow files (review_gate.yml, triage_pr_with_llm.yml) from DESTRUCTIVE_GATE_ENV and LLM_CLIENT_INSTALLER_WORKFLOWS; all four remaining workflows retain unchanged guardrail coverage.

Reviews (1): Last reviewed commit: "fix(test): drop references to removed Ag..." | Re-trigger Greptile

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ryan-crabbe-berri
ryan-crabbe-berri merged commit ba0233c into litellm_internal_staging Jun 18, 2026
120 of 121 checks passed
@ryan-crabbe-berri
ryan-crabbe-berri deleted the litellm_fix_stale_triage_workflow_test branch June 18, 2026 22:47
fzowl pushed a commit to fzowl/litellm that referenced this pull request Jun 24, 2026
…0791)

PR BerriAI#30784 deleted .github/workflows/review_gate.yml and
triage_pr_with_llm.yml, but test_github_triage_workflows.py still
listed both in its parametrize tables, so _load_workflow raised
FileNotFoundError for every case naming them.

Remove the two stale entries from DESTRUCTIVE_GATE_ENV and
LLM_CLIENT_INSTALLER_WORKFLOWS; the remaining four workflows that still
exist keep their guardrail coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants