fix(test): drop references to removed Agent Shin workflows - #30791
Conversation
PR #30784 deleted .github/workflows/review_gate.yml and triage_pr_with_llm.yml, but test_github_triage_workflows.py still listed both in its parametrize tables, so _load_workflow raised FileNotFoundError for every case naming them. Remove the two stale entries from DESTRUCTIVE_GATE_ENV and LLM_CLIENT_INSTALLER_WORKFLOWS; the remaining four workflows that still exist keep their guardrail coverage.
Greptile SummaryThis PR removes two stale entries (
Confidence Score: 5/5Safe to merge — removes only the two dead entries that were causing test failures after the workflow files were deleted. The change is entirely surgical: two filename strings are removed from two lookup tables in a test file. No production code is touched, no assertions are weakened, and the four active workflows retain identical test coverage. No files require special attention.
|
| Filename | Overview |
|---|---|
| tests/test_litellm/test_github_triage_workflows.py | Removes stale references to two deleted workflow files (review_gate.yml, triage_pr_with_llm.yml) from DESTRUCTIVE_GATE_ENV and LLM_CLIENT_INSTALLER_WORKFLOWS; all four remaining workflows retain unchanged guardrail coverage. |
Reviews (1): Last reviewed commit: "fix(test): drop references to removed Ag..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ba0233c
into
litellm_internal_staging
…0791) PR BerriAI#30784 deleted .github/workflows/review_gate.yml and triage_pr_with_llm.yml, but test_github_triage_workflows.py still listed both in its parametrize tables, so _load_workflow raised FileNotFoundError for every case naming them. Remove the two stale entries from DESTRUCTIVE_GATE_ENV and LLM_CLIENT_INSTALLER_WORKFLOWS; the remaining four workflows that still exist keep their guardrail coverage.
Relevant issues
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
make test-unit@greptileaiand received a Confidence Score of at least 4/5 before requesting a maintainer reviewScreenshots / Proof of Fix
Before, on
litellm_internal_staging, six cases failed because the two workflow files they parametrize over no longer exist:After:
Type
✅ Test
Changes
#30784 removed the
pull_request_targetAgent Shin workflows, deleting.github/workflows/review_gate.ymland.github/workflows/triage_pr_with_llm.yml.tests/test_litellm/test_github_triage_workflows.pystill named both files inDESTRUCTIVE_GATE_ENVandLLM_CLIENT_INSTALLER_WORKFLOWS, and_load_workflowreads each file with no existence guard, so every parametrized case for the two deleted workflows raisedFileNotFoundError.This drops the two stale entries from both tables. The four workflows that still exist (
triage_issue_with_llm.yml,close_low_quality_prs.yml,triage_reconsider.yml,triage_rollout_heads_up.yml) keep their guardrail coverage unchanged