ci(zizmor): also run on litellm_internal_staging - #30789
Conversation
Drop the two Agent Shin workflows that ran on the pull_request_target trigger: the PR triage workflow and the review gate. Both were dry-run and gated behind AGENT_SHIN_ENABLED, so no live automation changes. The shared scripts under .github/scripts stay in place; four other Agent Shin workflows still depend on them and run on schedule, dispatch, and issue events rather than pull_request_target
…itellm_/hopeful-kilby-f48a77
Greptile SummaryThis PR widens the trigger filters in the zizmor GitHub Actions Security Analysis workflow to include
Confidence Score: 5/5Safe to merge — the change is a two-line addition to a CI trigger filter with no effect on application code. Only one workflow file is modified, and the change simply adds a branch name to two existing filter lists. The workflow itself already follows GitHub Actions hardening best practices (pinned SHA references, minimal scoped permissions, persist-credentials: false). There is no application code, no logic change, and no new attack surface introduced. No files require special attention.
|
| Filename | Overview |
|---|---|
| .github/workflows/zizmor.yml | Adds litellm_internal_staging to the push and pull_request branch filters so the zizmor security-analysis workflow also runs on the primary integration branch. |
Reviews (1): Last reviewed commit: "ci(zizmor): also run on litellm_internal..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
e7532b7
into
litellm_internal_staging
* chore(ci): remove Agent Shin pull_request_target workflows Drop the two Agent Shin workflows that ran on the pull_request_target trigger: the PR triage workflow and the review gate. Both were dry-run and gated behind AGENT_SHIN_ENABLED, so no live automation changes. The shared scripts under .github/scripts stay in place; four other Agent Shin workflows still depend on them and run on schedule, dispatch, and issue events rather than pull_request_target * ci(zizmor): also run on litellm_internal_staging
Relevant issues
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
make test-unit@greptileaiand received a Confidence Score of at least 4/5 before requesting a maintainer reviewCI (LiteLLM team)
Branch creation CI run
Link:
CI run for the last commit
Link:
Merge / cherry-pick CI run
Links:
Screenshots / Proof of Fix
The zizmor workflow triggered only on
main, so pull requests targetinglitellm_internal_staging(the branch nearly all internal development goes through) were never analyzed. This addslitellm_internal_stagingto both thepushandpull_requestbranch filtersTo confirm the workflow still runs cleanly under the new config, I temporarily added this feature branch to the
pushfilter, pushed, and got a green run, then removed the temporary entry so the final diff only addslitellm_internal_staging. The verification run, all steps green including the zizmor step: https://github.com/BerriAI/litellm/actions/runs/27789888213Note for reviewers: for
pull_requestevents GitHub reads the trigger config from the base branch, so this starts covering staging-targeted PRs only once it is merged intolitellm_internal_staging; it does not retroactively run on already-open PRsType
🚄 Infrastructure
Changes
Adds
litellm_internal_stagingto thepushandpull_requestbranch filters in.github/workflows/zizmor.ymlso the GitHub Actions analysis runs on the primary integration branch, not justmain