-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
fix(health): correct bedrock embedding health checks #30583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mateo-berri
merged 4 commits into
litellm_internal_staging
from
litellm_fix_bedrock_embedding_health_checks
Jun 17, 2026
+176
−26
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
48f03ed
fix(health): correct bedrock embedding health checks
mateo-berri 63174ac
fix(health): preserve explicit custom_llm_provider on bedrock probe
mateo-berri f95fb4c
test(health): assert resolved mode reaches the ahealth_check probe
mateo-berri 66692e2
fix(health): resolve probe mode once for reasoning_effort and audio_s…
mateo-berri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would we remove the literal from this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahealth_checkonly usesmodeas a lookup key into its handler dict and already validates it at runtime (raises "Mode X not supported" for misses), and it even reassignsmodefrom the cost map internally; so theLiteralwas stricter than the function's own behavior. On top of that, the resolved mode also drives themax_tokens/reasoning_effort/voicedecisions, which need the raw string to recognize non-chat modes; if we narrowed it to the literal union, a mode likemoderationwould fail validation, collapse toNone, get treated aschat, and themax_tokens400 bug would come back. Widening tostr | Nonejust makes the signature match what the function actually does; keeping the literal would require acastthat asserts a type the runtime values don't really satisfy