Skip to content

fix(helm): wire envFrom secrets and configmaps into migrations job (closes #30311) #30325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsushanth wants to merge 1 commit into
base: litellm_internal_staging
Choose a base branch
from
+64 −0
Open

fix(helm): wire envFrom secrets and configmaps into migrations job (closes #30311) #30325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions helm/litellm-helm/templates/migrations-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,15 @@ spec:
{{- end }}
- name: DISABLE_SCHEMA_UPDATE
value: "false" # always run the migration from the Helm PreSync hook, override the value set
envFrom:
{{- range .Values.environmentSecrets }}
- secretRef:
name: {{ . }}
{{- end }}
{{- range .Values.environmentConfigMaps }}
- configMapRef:
name: {{ . }}
{{- end }}
{{- with .Values.volumeMounts }}
volumeMounts:
{{- toYaml . | nindent 12 }}
Expand Down
55 changes: 55 additions & 0 deletions helm/litellm-helm/tests/migrations-job_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,61 @@ tests:
name: init-tpl
image: "ghcr.io/berriai/litellm-database:test"
command: ["echo", "hello"]
- it: should work with environmentSecrets
template: migrations-job.yaml
set:
migrationJob:
enabled: true
environmentSecrets:
- litellm-env-secret
- litellm-extra-secret
asserts:
- contains:
path: spec.template.spec.containers[0].envFrom
content:
secretRef:
name: litellm-env-secret
- contains:
path: spec.template.spec.containers[0].envFrom
content:
secretRef:
name: litellm-extra-secret

- it: should work with environmentConfigMaps
template: migrations-job.yaml
set:
migrationJob:
enabled: true
environmentConfigMaps:
- litellm-env-configmap
asserts:
- contains:
path: spec.template.spec.containers[0].envFrom
content:
configMapRef:
name: litellm-env-configmap

- it: should work with both environmentSecrets and environmentConfigMaps
template: migrations-job.yaml
set:
migrationJob:
enabled: true
environmentSecrets:
- litellm-env-secret
environmentConfigMaps:
- litellm-env-configmap
asserts:
- contains:
path: spec.template.spec.containers[0].envFrom
content:
secretRef:
name: litellm-env-secret
- contains:
path: spec.template.spec.containers[0].envFrom
content:
configMapRef:
name: litellm-env-configmap

- it: should work with extraContainers
template: migrations-job.yaml
set:
Expand Down
Loading