-
-
Notifications
You must be signed in to change notification settings - Fork 11k
chore(release): backport #30064, #29991, #30009 to stable/1.86.x and cut 1.86.5 #30148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
59ae344
Add Claude Fable 5 across Anthropic, Bedrock, Vertex AI, and Azure AI…
mateo-berri 1038a68
feat(guardrails): capture user and model metadata in CrowdStrike AIDR
kenany 2d2fb8c
fix(guardrails): read CrowdStrike AIDR identity from both metadata ba…
yuneng-berri 5cea68f
fix(proxy): authorize batch files using upload target_model_names (LI…
Sameerlite 400f178
bump: version 1.86.4 → 1.86.5
yuneng-berri 0fd4cdf
chore: refresh uv.lock for 1.86.5
yuneng-berri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_supports_sampling_paramsThe team's convention is that model-specific capability flags belong exclusively in
model_prices_and_context_window.json, read viaget_model_info. The fallback name list here ("fable","opus-4-7","opus-4-8", …) diverges from that pattern: a future model that removes sampling params but uses an unfamiliar name would silently pass through until the hardcoded list is extended, while a model whose name accidentally contains"fable"would be incorrectly gated even if it supports sampling params.The primary map-driven path (
_get_model_capability) already handles all the newly-added entries correctly. Removing the name fallback and relying solely on the map would be the safest long-term approach — any caller on an old map that lackssupports_sampling_paramswould transparently forward params rather than silently dropping them, which is the safe default.Rule Used: What: Do not hardcode model-specific flags in the ... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!