-
-
Notifications
You must be signed in to change notification settings - Fork 11k
feat: add opt-in healthy_only filter to GET /v1/models #30130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Sameerlite
merged 6 commits into
BerriAI:litellm_oss_110626
from
nix-tkobayashi:feat/healthy-only-models-filter
Jun 11, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e58a561
Merge pull request #27906 from BerriAI/litellm_internal_staging
shin-berri a72414a
Merge pull request #28100 from BerriAI/litellm_internal_staging
yuneng-berri 79b4578
Merge pull request #28292 from BerriAI/litellm_internal_staging
yuneng-berri 35f6961
Merge pull request #28680 from BerriAI/litellm_internal_staging
yuneng-berri 1102f3b
feat: add opt-in healthy_only filter to GET /v1/models
nix-tkobayashi 1f79d6c
docs: address Greptile review notes
nix-tkobayashi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| """ | ||
| Tests for the opt-in `healthy_only` filter on GET /v1/models (`model_list`). | ||
| """ | ||
|
|
||
| from unittest.mock import AsyncMock, MagicMock | ||
|
|
||
| import pytest | ||
|
|
||
| from litellm.proxy import proxy_server | ||
| from litellm.proxy._types import UserAPIKeyAuth | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def patched_model_list(monkeypatch): | ||
| """Stub router + utility helpers used by `model_list`.""" | ||
| from litellm.proxy import utils as proxy_utils | ||
|
|
||
| router = MagicMock() | ||
| router.get_fully_blocked_model_names = MagicMock(return_value=set()) | ||
| router.async_get_fully_unhealthy_model_names = AsyncMock( | ||
| return_value={"claude-sonnet"} | ||
| ) | ||
|
|
||
| monkeypatch.setattr(proxy_server, "llm_router", router) | ||
| monkeypatch.setattr(proxy_server, "user_model", None) | ||
|
|
||
| async def _fake_get_available_models_for_user(**kwargs): | ||
| return ["gpt-4", "claude-sonnet"] | ||
|
|
||
| monkeypatch.setattr( | ||
| proxy_utils, | ||
| "get_available_models_for_user", | ||
| _fake_get_available_models_for_user, | ||
| ) | ||
|
|
||
| def _fake_create_model_info_response(model_id, provider="openai", **kwargs): | ||
| return {"id": model_id, "object": "model", "created": 0, "owned_by": provider} | ||
|
|
||
| monkeypatch.setattr( | ||
| proxy_utils, "create_model_info_response", _fake_create_model_info_response | ||
| ) | ||
|
|
||
| return router | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_model_list_healthy_only_hides_fully_unhealthy_models( | ||
| patched_model_list, | ||
| ): | ||
| response = await proxy_server.model_list( | ||
| user_api_key_dict=UserAPIKeyAuth(api_key="sk-test"), | ||
| healthy_only=True, | ||
| ) | ||
| assert [m["id"] for m in response["data"]] == ["gpt-4"] | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_model_list_default_keeps_unhealthy_models(patched_model_list): | ||
| response = await proxy_server.model_list( | ||
| user_api_key_dict=UserAPIKeyAuth(api_key="sk-test"), | ||
| ) | ||
| assert [m["id"] for m in response["data"]] == ["gpt-4", "claude-sonnet"] | ||
| patched_model_list.async_get_fully_unhealthy_model_names.assert_not_awaited() | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_model_list_healthy_only_applies_to_scope_expand( | ||
| patched_model_list, monkeypatch | ||
| ): | ||
| from litellm.proxy.auth import model_checks | ||
| from litellm.proxy.management_endpoints import common_utils | ||
|
|
||
| async def _fake_admin(**kwargs): | ||
| return True | ||
|
|
||
| monkeypatch.setattr(common_utils, "_user_has_admin_privileges", _fake_admin) | ||
| monkeypatch.setattr( | ||
| model_checks, | ||
| "get_complete_model_list", | ||
| lambda **kwargs: ["gpt-4", "claude-sonnet"], | ||
| ) | ||
| patched_model_list.get_model_names = MagicMock( | ||
| return_value=["gpt-4", "claude-sonnet"] | ||
| ) | ||
| patched_model_list.get_model_access_groups = MagicMock(return_value={}) | ||
|
|
||
| response = await proxy_server.model_list( | ||
| user_api_key_dict=UserAPIKeyAuth(api_key="sk-test"), | ||
| scope="expand", | ||
| healthy_only=True, | ||
| ) | ||
| assert [m["id"] for m in response["data"]] == ["gpt-4"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.