fix(ui): warn that team models are deleted in the delete-team modal - #29990
Conversation
The delete-team confirmation modal warned that a team's keys would be deleted but said nothing about models. #29977 made team deletion also delete the team's BYOK models, so the modal copy was understating what gets removed. The warning banner now mentions models alongside keys, and the always-shown confirmation message does too so a team that has models but no keys (the banner only renders when keys exist) still gets warned.
…itellm_/competent-bassi-2731b1
Greptile SummaryUpdates the delete-team confirmation modal copy to reflect that BYOK models are deleted alongside keys when a team is removed, following the behaviour introduced in #29977.
Confidence Score: 5/5Safe to merge — the change is limited to two UI strings in the delete-team modal with no logic or data-flow modifications. Both changed lines are inert copy strings inside template literals. The surrounding conditional logic, component props, and deletion handler are untouched. The two new tests are additive and independently verify both the banner and the confirmation message for the with-keys and no-keys scenarios. No files require special attention.
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/src/components/OldTeams.tsx | Two copy strings in the delete-team modal updated to mention model deletion alongside key deletion; no logic changes. |
| ui/litellm-dashboard/src/components/OldTeams.test.tsx | Two new test cases added covering the warning banner (keys > 0) and confirmation message (keys = 0) paths for model-deletion copy; no existing tests modified. |
Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/lit..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…erriAI#29990) The delete-team confirmation modal warned that a team's keys would be deleted but said nothing about models. BerriAI#29977 made team deletion also delete the team's BYOK models, so the modal copy was understating what gets removed. The warning banner now mentions models alongside keys, and the always-shown confirmation message does too so a team that has models but no keys (the banner only renders when keys exist) still gets warned.
2 participants
Relevant issues
Follow-up to #29977, which made deleting a team also delete that team's BYOK models. The delete-team confirmation modal still only warned about keys, so it understated what the action removes
Linear ticket
N/A
Pre-Submission checklist
make test-unit(ran the touched UI test file with vitest instead; see Changes)@greptileaiand received a Confidence Score of at least 4/5 before requesting a maintainer reviewScreenshots / Proof of Fix
This is UI copy in the delete-team confirmation modal. To see it against a proxy on
localhost:4000:Type
Bug Fix
Changes
The delete-team modal in
OldTeams.tsxhas two pieces of copy: a warning banner that renders only when the team has keys, and a confirmation message shown in every case. Both enumerated keys but not models. After #29977 a team's BYOK models are deleted along with the team, so the copy was telling the user less than what happensThe banner now mentions models next to keys. The confirmation message mentions them too, which matters because the banner is hidden when the team has no keys; a team with models but zero keys would otherwise get no warning about its models being removed. The info card was left as is on purpose; the team object's
modelsfield is the team's allowed-model access list rather than the BYOK models it owns, so surfacing that count would be misleadingTests live in
OldTeams.test.tsx. One opens the delete modal for a team with keys and asserts both the banner and the message mention models; one covers the no-keys path, asserting no banner renders but the message still warns about models. Reverting either string to the old copy fails both tests