Repository navigation
Cherry-pick #29311, #29343, #29358, #27913, and #29447 onto stable/1.85.x #29460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fcdf023
[internal copy of #29089] fix: duplicate claude code traces (#29311)
mateo-berri 87b0e47
refactor(proxy/auth): normalize Bearer prefix in safe-hash helper (#2…
yuneng-berri a06ec43
fix(reset_budget): write only {spend, budget_reset_at} and stop pre-z…
yuneng-berri 0e2510d
fix(rate-limit): stop v3 limiter from leaking internal stash to provi…
mateo-berri acbbfe9
fix: stop use_chat_completions_api flag from leaking into provider re…
mateo-berri 8824745
fix(passthrough): extract _build_passthrough_logging_result helper
yuneng-berri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should_run_loggingguard bypassed for all assembled stream calls toasync_success_handlerasync_success_handlerpreviously checkedshould_run_loggingunconditionally to prevent double logging. The new condition skips that guard whenever_is_assembled_stream_successreturns True, relying on thehas_dispatched_final_stream_successflag set bydispatch_success_handlers. Any call site that invokesasync_success_handlerdirectly with an assembled stream result (bypassingdispatch_success_handlers) will now skip the double-log guard with no fallback. The comment should at minimum make this assumption explicit so future callers don't inadvertently create double-logging regressions.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!