test(e2e): cover Internal Viewer nav, key, and team-info gating - #29075
Merged
yuneng-berri merged 2 commits intoMay 29, 2026
Conversation
Three previously-uncovered manual-QA paths for the Internal Viewer role: - Nav only renders the read-only sections; admin-only items (Internal Users, Organizations, Models + Endpoints) stay hidden. - Virtual Keys page hides Create New Key, and the key detail view hides Regenerate / Reset Spend / Delete actions. - Team info page hides Members and Settings tabs for the viewer.
Contributor
Greptile SummaryAdds a new Playwright e2e spec covering three Internal Viewer role-gating scenarios that were previously manual-QA items. All assertions use
Confidence Score: 5/5This PR is safe to merge — it adds only new test code and touches no production logic. The change is a purely additive test file with no modifications to production code, helpers, or fixtures. All previously-raised review concerns have been resolved: the networkidle race is eliminated by using navigateToPage, the redundant popup-dismiss call is gone, the Virtual Keys tab is now asserted visible, and the hidden-element checks use toHaveCount(0) consistently throughout. No files require special attention.
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/e2e_tests/tests/internal-viewer/internalViewer.spec.ts | New test file adding three e2e scenarios for Internal Viewer role gating: nav visibility, key-page write-control hiding, and team info tab filtering. All previously-raised review concerns have been resolved in this revision. |
Reviews (2): Last reviewed commit: "test(e2e): scope viewer nav to sidebar, ..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Address review feedback on the Internal Viewer e2e spec: - Scope the nav test to the sidebar complementary landmark and match items by link role + accessible name. The prior CSS nav, aside selector grabbed the top bar (the sidebar is a complementary landmark, not a <nav> tag), so the assertions never hit the real nav links. - Land via navigateToPage so the networkidle wait settles the role-gated nav before asserting. - Assert the Virtual Keys tab is visible (was only commented). - Use toHaveCount(0) for hidden team tabs to match the nav block; tabs are conditionally rendered, not CSS-hidden. - Drop redundant dismissFeedbackPopup calls (navigateToPage already dismisses internally).
Contributor
Author
|
@greptileai re review |
yuneng-berri
approved these changes
May 29, 2026
yuneng-berri
merged commit May 29, 2026
10bda44
into
litellm_internal_staging
114 of 118 checks passed
fzowl
pushed a commit
to fzowl/litellm
that referenced
this pull request
Jun 24, 2026
…iAI#29075) * test(e2e): cover Internal Viewer nav, key, and team-info gating Three previously-uncovered manual-QA paths for the Internal Viewer role: - Nav only renders the read-only sections; admin-only items (Internal Users, Organizations, Models + Endpoints) stay hidden. - Virtual Keys page hides Create New Key, and the key detail view hides Regenerate / Reset Spend / Delete actions. - Team info page hides Members and Settings tabs for the viewer. * test(e2e): scope viewer nav to sidebar, strengthen tab assertions Address review feedback on the Internal Viewer e2e spec: - Scope the nav test to the sidebar complementary landmark and match items by link role + accessible name. The prior CSS nav, aside selector grabbed the top bar (the sidebar is a complementary landmark, not a <nav> tag), so the assertions never hit the real nav links. - Land via navigateToPage so the networkidle wait settles the role-gated nav before asserting. - Assert the Virtual Keys tab is visible (was only commented). - Use toHaveCount(0) for hidden team tabs to match the nav block; tabs are conditionally rendered, not CSS-hidden. - Drop redundant dismissFeedbackPopup calls (navigateToPage already dismisses internally).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds e2e coverage for three previously-uncovered Internal Viewer manual-QA items, using
INTERNAL_VIEWER_STORAGE_PATH:Test plan
e2e_tests/tests/internal-viewer/internalViewer.spec.ts::Nav shows only the allowed options for the Internal Viewer rolee2e_tests/tests/internal-viewer/internalViewer.spec.ts::Virtual Keys page hides Create / Regenerate / Reset / Delete controlse2e_tests/tests/internal-viewer/internalViewer.spec.ts::Team info page omits Members and Settings tabs for an Internal ViewerRefs LIT-3093