test(e2e): cover Internal User key modal, team info, key page - #29074
Merged
yuneng-berri merged 2 commits intoMay 29, 2026
Conversation
Three previously-uncovered manual-QA paths for the Internal User role: - Create Key modal — confirm the team dropdown is populated with the user's teams (verifying the role-scoped UI flow exists). - Team info page — confirm the Settings/Members tabs are hidden for a regular team member; only the read-only tabs render. - Virtual Keys page — confirm the proxy's internal litellm-dashboard team keys never leak into an internal user's table.
Contributor
Greptile SummaryThis PR adds E2E coverage for three previously-uncovered Internal User manual-QA scenarios and consolidates a shared helper into the navigation module.
Confidence Score: 5/5Safe to merge — changes are purely additive E2E tests and a shared helper refactor with no production code touched. All three changed files are test infrastructure only. The helper consolidation is a clean refactor with identical behaviour, and the new tests address the gaps called out in earlier review threads. No files require special attention.
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/e2e_tests/helpers/navigation.ts | Moved clickTeamId helper from teams.spec.ts into the shared navigation module as an exported function, enabling reuse across test files. |
| ui/litellm-dashboard/e2e_tests/tests/internal-user/internalUser.spec.ts | New E2E test file covering three internal-user scenarios: team dropdown in Create Key modal, Settings/Members tab visibility on team info page, and litellm-dashboard key filtering on Virtual Keys page. |
| ui/litellm-dashboard/e2e_tests/tests/proxy-admin/teams.spec.ts | Removed the locally-defined clickTeamId function and replaced it with the now-shared import from helpers/navigation.ts; no behavioural changes. |
Reviews (2): Last reviewed commit: "test(e2e): share clickTeamId helper, str..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Address review feedback on the Internal User e2e spec: - Extract clickTeamId into helpers/navigation.ts; import in both internalUser and teams specs instead of duplicating it. - Anchor the litellm-dashboard absence check on the user's own seeded key so it cannot pass vacuously against an empty table. - Drop redundant dismissFeedbackPopup calls (navigateToPage already dismisses internally).
Contributor
Author
|
@greptileai re review |
yuneng-berri
approved these changes
May 29, 2026
yuneng-berri
merged commit May 29, 2026
fcd5760
into
litellm_internal_staging
114 of 118 checks passed
fzowl
pushed a commit
to fzowl/litellm
that referenced
this pull request
Jun 24, 2026
…I#29074) * test(e2e): cover Internal User key modal, team info, key page Three previously-uncovered manual-QA paths for the Internal User role: - Create Key modal — confirm the team dropdown is populated with the user's teams (verifying the role-scoped UI flow exists). - Team info page — confirm the Settings/Members tabs are hidden for a regular team member; only the read-only tabs render. - Virtual Keys page — confirm the proxy's internal litellm-dashboard team keys never leak into an internal user's table. * test(e2e): share clickTeamId helper, strengthen key-filter assertion Address review feedback on the Internal User e2e spec: - Extract clickTeamId into helpers/navigation.ts; import in both internalUser and teams specs instead of duplicating it. - Anchor the litellm-dashboard absence check on the user's own seeded key so it cannot pass vacuously against an empty table. - Drop redundant dismissFeedbackPopup calls (navigateToPage already dismisses internally).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds e2e coverage for three previously-uncovered Internal User manual-QA items, using
INTERNAL_USER_STORAGE_PATH:Test plan
e2e_tests/tests/internal-user/internalUser.spec.ts::Create Key modal shows the team dropdown populated with the user's teamse2e_tests/tests/internal-user/internalUser.spec.ts::Team info page omits the Settings tab for non-admin memberse2e_tests/tests/internal-user/internalUser.spec.ts::Virtual Keys page does not surface litellm-dashboard team keysRefs LIT-3093