fix(ui): exclude vector_store_ids from model edit JSON textarea - #27597
fix(ui): exclude vector_store_ids from model edit JSON textarea#27597Jwrede wants to merge 1 commit into
Conversation
Fields with dedicated form inputs (vector_store_ids, guardrails, tags) were included in the litellm_extra_params JSON textarea. On save, these duplicated values from the JSON could override the dedicated form field logic, injecting unwanted parameters into litellm_params for non-OpenAI models. Exclude these fields from the JSON textarea (matching the existing litellm_credential_name exclusion) and delete them from parsed JSON on submit. Fixes BerriAI#27117
Greptile SummaryThis PR fixes a duplication bug in the model edit form where
Confidence Score: 5/5Safe to merge — the change is narrowly scoped to excluding three fields from a JSON textarea, with the fix covered by a new test and no existing tests modified. The fix is minimal and additive: it extends an already-proven pattern ( No files require special attention.
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/src/components/model_info_view.tsx | Excludes vector_store_ids, guardrails, and tags from the JSON textarea initial value and strips them on submit — mirrors existing litellm_credential_name exclusion. Dedicated form-field handlers at lines 274–283 remain the authoritative source for those values. |
| ui/litellm-dashboard/src/components/model_info_view.test.tsx | Adds a new test verifying that vector_store_ids does not appear in the JSON textarea even when the model already has them; no existing tests are modified or weakened. |
Reviews (2): Last reviewed commit: "fix(ui): exclude vector_store_ids from m..." | Re-trigger Greptile
|
@greptileai review |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Summary
vector_store_ids,guardrails, andtagsfrom thelitellm_extra_paramsJSON textarea in the model edit form, matching the existinglitellm_credential_nameexclusionThese fields all have dedicated form inputs that handle their own submission logic. Including them in the catch-all JSON textarea creates a duplication path where the JSON values can override the form field logic, silently injecting parameters like
vector_store_ids: []intolitellm_paramsfor non-OpenAI models.Fixes #27117
Test plan
should not include vector_store_ids in update payload when model has nonepassesshould not leak vector_store_ids from JSON textarea when model already has them-- verifies the JSON textarea does not containvector_store_idseven when the model has them