[Fix] Team UI: handle legacy dict shape for metadata.guardrails - #27224
Merged
ryan-crabbe-berri merged 2 commits intoMay 5, 2026
Conversation
A team can have metadata.guardrails stored as {"modify_guardrails": bool}
(the permission-flag shape introduced in PR #4810) rather than the
expected string[]. The opt-out logic added in PR #25575 calls .filter()
on this field, which throws TypeError on a dict and crashes the team
detail page.
Add a safeGuardrailsList helper that returns [] when the field is not
an array, and route the three read sites through it.
Contributor
Greptile SummaryGuards all six array-operation call sites in
Confidence Score: 5/5Narrow defensive UI fix; no logic changes, all affected call sites covered. The change is a targeted type-guard at every site that performs array operations on info.metadata.guardrails and info.metadata.opted_out_global_guardrails. All six call sites in the file have been updated, the save path remains unchanged and continues to write clean string[] values, and no other component reads these fields from the legacy shape. The risk surface is minimal. No files require special attention.
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/src/components/team/TeamInfo.tsx | Adds Array.isArray() guards at all 6 call sites that read info.metadata.guardrails or info.metadata.opted_out_global_guardrails, preventing a crash when legacy dict-shaped data is present |
Reviews (2): Last reviewed commit: "[Fix] Team UI: inline Array.isArray guar..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Replace the safeGuardrailsList helper with inline Array.isArray checks at each call site, and apply the same guard to opted_out_global_guardrails for consistency. No known legacy dict rows for opted_out_global_guardrails, but the unguarded `|| []` pattern is the same shape risk. Six call sites now defended directly: three for metadata.guardrails and three for metadata.opted_out_global_guardrails.
Contributor
Author
|
@greptileai re review |
yuneng-berri
approved these changes
May 5, 2026
ryan-crabbe-berri
merged commit May 5, 2026
1b25f85
into
litellm_internal_staging
114 of 115 checks passed
fzowl
pushed a commit
to fzowl/litellm
that referenced
this pull request
Jun 24, 2026
…iAI#27224) * [Fix] Team UI: handle legacy dict shape for metadata.guardrails A team can have metadata.guardrails stored as {"modify_guardrails": bool} (the permission-flag shape introduced in PR BerriAI#4810) rather than the expected string[]. The opt-out logic added in PR BerriAI#25575 calls .filter() on this field, which throws TypeError on a dict and crashes the team detail page. Add a safeGuardrailsList helper that returns [] when the field is not an array, and route the three read sites through it. * [Fix] Team UI: inline Array.isArray guards for guardrails metadata Replace the safeGuardrailsList helper with inline Array.isArray checks at each call site, and apply the same guard to opted_out_global_guardrails for consistency. No known legacy dict rows for opted_out_global_guardrails, but the unguarded `|| []` pattern is the same shape risk. Six call sites now defended directly: three for metadata.guardrails and three for metadata.opted_out_global_guardrails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking into a team whose
metadata.guardrailsis stored as a dict (e.g.{"modify_guardrails": false}) instead of astring[]crashes the team detail page withTypeError: ((intermediate value) || []).filter is not a function.Adds inline
Array.isArray(...)guards at the six read sites inTeamInfo.tsxforinfo.metadata.guardrailsandinfo.metadata.opted_out_global_guardrails. Affected teams now load cleanly; saving the form heals the row. Root-cause follow-up tracked in LIT-31.Screenshots