Skip to content

[UI] Rename "Default" key type to "Full Access" and reorder dropdown - #27218

Merged
ryan-crabbe-berri merged 1 commit into
litellm_internal_stagingfrom
litellm_fix-key-default
May 9, 2026
Merged

[UI] Rename "Default" key type to "Full Access" and reorder dropdown#27218
ryan-crabbe-berri merged 1 commit into
litellm_internal_stagingfrom
litellm_fix-key-default

Conversation

@ryan-crabbe-berri

@ryan-crabbe-berri ryan-crabbe-berri commented May 5, 2026

Copy link
Copy Markdown
Contributor

Resolves LIT-2680.

Summary

The Create New Key dialog (Virtual Keys page) had a "Default" key-type option that was misleading on two counts:

  1. It was not the actual default selection — AI APIs is what's preselected.
  2. It grants access to all routes (AI APIs + Management + read-only), broader than the "AI APIs + Management" description implied.

This PR:

  • Renames the option to Full Access with an accurate description ("Can call all routes (AI APIs, Management, and read-only)").
  • Reorders the dropdown to AI APIs → Management → Full Access, matching the actual default selection order.
  • Replaces the raw <div>-based label/description markup with antd Typography.Text / Typography.Paragraph for consistency with the rest of the UI.

UI-only change. The underlying enum value ("default") is unchanged, so the /key/generate API contract and existing keys are unaffected.

Screenshot

Screenshot 2026-05-05 at 11 39 38 AM

Test plan

  • Open the Virtual Keys page, click "Create New Key", and confirm the Key Type dropdown shows AI APIs → Management → Full Access in that order.
  • Confirm AI APIs is preselected.
  • Select Full Access and create a key; verify it can call both AI API and management routes.
  • Verify the same dropdown looks correct when the modal is opened from Tag detail and Project creation flows.

The Create New Key dialog had a "Default" key-type option that was
misleading: it was not the actual default selection (AI APIs is), and it
grants access to all routes — broader than the description implied.

Rename the option to "Full Access" with an accurate description, and
reorder the dropdown to AI APIs → Management → Full Access. Switch the
inner labels to antd Typography for consistency with the rest of the UI.

UI-only change; the underlying enum value ("default") is unchanged so
the API contract is preserved.
@greptile-apps

greptile-apps Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This is a purely cosmetic UI change to the Create New Key dialog that renames the misleading "Default" key-type option to "Full Access" and moves it to the end of the dropdown so the preselected "AI APIs" option appears first.

  • The rename and reorder are correct: the underlying Option value=\"default\" is preserved, so /key/generate API contracts and any stored key-type values are unaffected.
  • Raw <div>-based label markup is consistently replaced with antd Typography.Text strong / Typography.Paragraph across all three options, matching the rest of the UI and correctly overriding the paragraph's default margin with margin: \"2px 0 0\".

Confidence Score: 5/5

Safe to merge — purely cosmetic, no logic or API contract changes.

The change only touches dropdown label text, option ordering, and a swap from raw div markup to antd Typography components. The "default" enum value, form initialValue, and defaultValue are all left untouched, so no backend or stored-state impact is possible.

No files require special attention.

Important Files Changed

Filename Overview
ui/litellm-dashboard/src/components/organisms/create_key_button.tsx Renames the "Default" key-type option to "Full Access", reorders the dropdown (AI APIs → Management → Full Access), and replaces raw div-based label markup with antd Typography.Text/Typography.Paragraph. The underlying "default" enum value and form initialValue/defaultValue are preserved.

Reviews (1): Last reviewed commit: "[UI] Rename "Default" key type to "Full ..." | Re-trigger Greptile

@ryan-crabbe-berri
ryan-crabbe-berri merged commit 0f11b3e into litellm_internal_staging May 9, 2026
113 of 115 checks passed
@ryan-crabbe-berri
ryan-crabbe-berri deleted the litellm_fix-key-default branch May 9, 2026 16:36
Setsuna-Yukirin pushed a commit to Setsuna-Yukirin/litellm that referenced this pull request May 9, 2026
The antd mock omits Typography, which caused all 15 tests in
create_key_button.test.tsx to fail with "No 'Typography' export is
defined on the 'antd' mock" after BerriAI#27218 switched the key-type
dropdown labels to Typography.Text / Typography.Paragraph.

Add Typography (with .Text, .Paragraph, .Title subcomponents) to the
mock so the dropdown renders in the test environment.
fzowl pushed a commit to fzowl/litellm that referenced this pull request Jun 24, 2026
…erriAI#27218)

The Create New Key dialog had a "Default" key-type option that was
misleading: it was not the actual default selection (AI APIs is), and it
grants access to all routes — broader than the description implied.

Rename the option to "Full Access" with an accurate description, and
reorder the dropdown to AI APIs → Management → Full Access. Switch the
inner labels to antd Typography for consistency with the rest of the UI.

UI-only change; the underlying enum value ("default") is unchanged so
the API contract is preserved.
fzowl pushed a commit to fzowl/litellm that referenced this pull request Jun 24, 2026
The antd mock omits Typography, which caused all 15 tests in
create_key_button.test.tsx to fail with "No 'Typography' export is
defined on the 'antd' mock" after BerriAI#27218 switched the key-type
dropdown labels to Typography.Text / Typography.Paragraph.

Add Typography (with .Text, .Paragraph, .Title subcomponents) to the
mock so the dropdown renders in the test environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants