Conversation
Congrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Greptile SummaryThis PR adds pricing entries for Confidence Score: 5/5Safe to merge — pricing entries are structurally correct and the test guards against previously-reported regressions. All previously flagged issues have been addressed: No files require special attention.
|
| Filename | Overview |
|---|---|
| model_prices_and_context_window.json | Adds azure_ai/gpt-image-2 and azure_ai/gpt-image-to-image pricing entries — no output_cost_per_token or supports_pdf_input fields, matching the established gpt-image-1 pattern. |
| litellm/model_prices_and_context_window_backup.json | Backup registry updated with identical entries as the main JSON; stays in sync with model_prices_and_context_window.json. |
| tests/test_litellm/test_utils.py | New test validates both model entries against expected pricing values, and explicitly asserts output_cost_per_token is None and supports_pdf_input is None to guard against previously-reported regressions. |
| litellm/proxy/_lazy_openapi_snapshot.json | Auto-generated snapshot regenerated; fixes operationId values that were incorrectly set to *_delete for GET/PATCH/POST/PUT proxy routes (unrelated to pricing changes). |
Reviews (2): Last reviewed commit: "fix(azure): remove spurious cost fields ..." | Re-trigger Greptile
|
Hi @ishaan-jaff / @krrishdholakia , just a heads up that the failing check here ( This PR adds complete support for the Azure AI image models requested in #26765, including the missing |
e299100 to
9eebd63
Compare
5e1c1f9 to
7a06b72
Compare
|
Hi @ishaan-jaff / @krrishdholakia 👋 Final update: This PR is now 101% done. 42/42 CI checks are passing. |
|
+1 |
1 similar comment
|
+1 |
|
Awesome job getting this implemented! Resolving #26765 by adding the pricing support for Azure's new image generation models is going to be incredibly useful for the community. The code changes are very clean and well-structured. Keep up the great work! |
|
Hi @ryan-crabbe-berri / @yuneng-berri, I noticed you've been actively reviewing and merging PRs recently! This PR has been open for a while and is fully synced with the latest Could you please take a quick look and merge it if everything looks good? Thank you! |
BroderickHigby
left a comment
There was a problem hiding this comment.
{"linked_issue":"#26765","fix_shapes":["other"],"merge_gate":{"safe_for_high_rps_gateway":"no","one_liner":"Hold: the model-pricing entries are fine, but the PR also rewrites generated OpenAPI/dashboard schema artifacts and drops MCP app schemas/paths far outside the linked pricing issue.","unintended_consequences":["Generated API clients may lose MCP request/credential types even though the ticket only asks for model price-map entries.","The huge generated artifact churn makes a pricing-only change hard to review and can hide unrelated route/schema regressions behind green tests."],"hot_path_notes":["No proxy request hot path code is changed, but generated API/schema artifacts are broad surface consumed by UI and clients."],"what_would_make_yes":"Split or revert the generated OpenAPI/schema rewrites from this PR; keep only both model price-map entries and the cost-map regression test, or provide a separate PR proving the MCP schema shrink is intended."},"findings":[{"regression_archetype":"scope_expansion","bug_class":"pricing PR rewrites generated OpenAPI/dashboard schema and removes MCP schema surface","fix_locus":"litellm/proxy/_lazy_openapi_snapshot.json","sibling_loci":["ui/litellm-dashboard/src/lib/http/schema.d.ts"],"evidence":["model_prices_and_context_window.json:2531-2558 — the linked pricing change adds the two azure_ai image model entries requested by #26765.","tests/test_litellm/test_utils.py:4156-4187 — the added regression test only validates those two model-cost entries and explicitly ties the change to #26765.","litellm/proxy/_lazy_openapi_snapshot.json:13459-13464 — mcp_app is now an empty schemas/paths block after this pricing PR's generated snapshot rewrite.","litellm/proxy/_lazy_openapi_snapshot.json:13465-13469 — mcp_byok_oauth is also empty, while the linked issue did not ask for MCP or OpenAPI changes."],"breadth":"scope_expansion","recommended_fix":"Do not merge this as a pricing PR. Revert or split the generated OpenAPI and dashboard schema rewrites, then merge the two price-map entries plus their focused test; if the MCP schema shrink is intentional, ship it as a separate schema-generation PR with explicit reviewer ownership and client-impact proof."}]}
|
Hi @ryan-crabbe-berri / @yuneng-berri! Following up on the automated review above: the unintentional OpenAPI and MCP schema rewrites have been completely reverted. The PR is now perfectly clean and strictly isolated to just the two pricing additions and their tests. Let me know if it's good to merge! |
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 1 · PR risk: 0/10 |
|
Hey @Sameerlite can you give a review in this pr |
chore(ci): promote internal staging to main
chore(ci): promote internal staging to main
chore(ci): promote internal staging to main
chore(ci): promote internal staging to main
chore(ci): remerge internal staging
Adds pricing entries for new Azure AI image models. Prices: - Text Input: /M tokens - Image Input: /M tokens - Image Output: /M tokens Closes BerriAI#26765
5cddf3c to
4688d8d
Compare
Enhancement: Azure AI GPT-Image Pricing Support
This PR implements full pricing support for the new Azure AI image models as requested in #26765.
Key Improvements over existing PR #26866:
azure_ai/gpt-image-2and the missingazure_ai/gpt-image-to-imagealias requested in the issue.test_azure_ai_gpt_image_models_in_cost_map) to verify the pricing registry entries.litellm/model_prices_and_context_window_backup.json).Pricing Details:
Closes #26765