Repository navigation
[Fix] RBAC: Restore Admin Viewer Read Parity for Logs + Settings Pages #26846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yuneng-berri
merged 8 commits into
litellm_internal_staging
from
litellm_/pensive-bartik-e24048
May 1, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b1ee9c4
fix(rbac): restore admin-viewer read parity for Logs page + settings …
yuneng-berri cfda5e1
Merge remote-tracking branch 'origin/litellm_internal_staging' into l…
yuneng-berri f81fbda
[Fix] RBAC: Add /invitation/info to admin_viewer_routes
yuneng-berri 2fa6c60
[Fix] RBAC: Unblock Guardrails / Policies / MCP-filter reads + Keys /…
yuneng-berri 00145f9
[Fix] RBAC: Default-Allow GET for Admin Viewer + Models Tab Alignment
yuneng-berri 0423f51
[Fix] RBAC: Open Handler-Level Admin Reads + Hide UI Write Buttons fo…
yuneng-berri c78144c
Merge remote-tracking branch 'origin/litellm_internal_staging' into l…
yuneng-berri 6499fa7
[Fix] RBAC: Drop management_routes Write Fallback for Admin Viewer
yuneng-berri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High: Secrets exposure to read-only admin role
The
/get/config/callbackshandler (proxy_server.py ~line 13282) has no handler-level role check and returns decrypted values ofLANGFUSE_SECRET_KEY,AWS_SECRET_ACCESS_KEY,SMTP_PASSWORD,SLACK_WEBHOOK_URL, and other integration secrets. By adding this route toadmin_viewer_routes, anyPROXY_ADMIN_VIEW_ONLYuser can now retrieve these secrets.The other two callback routes (
/callbacks/list,/callbacks/configs) are safe — they return only callback names and static schema. Consider removing/get/config/callbacksfrom this list, or adding a_user_has_admin_viewguard inside the handler that redacts secret values for the view-only role.