fix(ui): move 'Store Prompts in Spend Logs' toggle to Admin Settings

[ryan-crabbe-berri]

Summary

• Move the "Store Prompts in Spend Logs" and "Maximum Spend Logs Retention Period" controls from a gear-icon modal on the Logs page into a new Logging Settings tab under Admin Settings.
• Reason: the gear was visible to every authenticated user on the Logs page even though /config/update and /config/list both require PROXY_ADMIN. Non-admins could open the modal, but the request would 403 on load and save, giving a confusing UX. Admin Settings is already gated to admins at the sidebar (all_admin_roles), so relocation is a defense-in-depth fix that also makes "global proxy setting" clearer than a gear on a per-user logs view.
• Remove the onOpenSettings prop chain (ConfigInfoMessage → LogDetailContent → LogDetailsDrawer). ConfigInfoMessage now tells users to toggle the setting under "Admin Settings → Logging Settings" inline.
• Refactor the save flow in LoggingSettings to use idiomatic React Query callbacks (mutate + onSuccess / onError / onSettled) instead of mutateAsync wrapped in try/catch. Eliminates a double-toast bug on save failure (both the per-call onError and the outer catch were notifying) and removes the awaited delete-then-update sequencing in favor of onSettled chaining.

Resolves LIT-2426

Screenshots

after

Test plan

• As an Admin, navigate to Admin Settings → Logging Settings, toggle Store Prompts, set a retention period, save — form reflects the saved values and a single success toast appears.
• As an Admin, clear the retention input and save — deletes the field then updates Store Prompts; success toast fires once.
• As an Admin, simulate a backend failure on save — exactly one error toast appears (no duplicate).
• As a non-admin (Internal User), visit the Logs page — gear icon is gone. Open a log entry with no prompt data — the "Request/Response Data Not Available" callout references Admin Settings → Logging Settings (no broken "open the settings" link).
• As a non-admin, confirm Admin Settings is not reachable from the sidebar.
• LoggingSettings test suite and the trimmed ConfigInfoMessage / LogDetailContent suites pass locally (npx vitest run src/components/Settings/AdminSettings/LoggingSettings).

[greptile-apps]

Greptile Summary

This PR relocates the "Store Prompts in Spend Logs" and "Maximum Spend Logs Retention Period" controls from a gear-icon modal on the Logs page (visible to all authenticated users) into a new Logging Settings tab under Admin Settings (gated to admins), and replaces the mutateAsync+try/catch save flow with idiomatic mutate+callbacks.

The three previously-flagged P1 concerns are resolved in this version:

• Double toast on save failure — eliminated by switching from mutateAsync+outer-catch to mutate+onError callback only.
• Stale form values after save — fixed by adding queryClient.invalidateQueries to both useDeleteProxyConfigField.onSuccess and useStoreRequestInSpendLogs.onSuccess, so the form key updates automatically after the cache is refreshed.
• Test timeout / mock gap — the new LoggingSettings test suite correctly mocks deleteField with onSettled and adds a toHaveBeenCalledTimes(1) assertion to guard against double-toast regressions.

Confidence Score: 5/5

Safe to merge — all previously flagged P1s are addressed, no new blocking issues found.

No P0 or P1 findings remain. The three previously raised P1s (double-toast, stale values, test timeout) are each verifiably resolved in this diff. Only two P2 observations exist: a missing hook-level test for useStoreRequestInSpendLogs invalidation, and a cosmetic double-invalidation when clearing the retention period.

No files require special attention.

Important Files Changed

Filename	Overview
ui/litellm-dashboard/src/components/Settings/AdminSettings/LoggingSettings/LoggingSettings.tsx	New component replacing SpendLogsSettingsModal; uses mutate+callbacks (no double-toast), form key resets on cache invalidation, save flow correctly handles delete-then-update via onSettled chaining.
ui/litellm-dashboard/src/app/(dashboard)/hooks/proxyConfig/useProxyConfig.ts	Exports proxyConfigKeys; adds invalidateQueries to useDeleteProxyConfigField.onSuccess — resolves the previously-flagged stale-form-values P1.
ui/litellm-dashboard/src/app/(dashboard)/hooks/storeRequestInSpendLogs/useStoreRequestInSpendLogs.ts	Adds invalidateQueries on success so the form key changes after a successful store-prompts update, triggering a form reset to server values.
ui/litellm-dashboard/src/components/Settings/AdminSettings/LoggingSettings/LoggingSettings.test.tsx	New test suite; correctly mocks deleteField with onSettled, adds toHaveBeenCalledTimes(1) to catch double-toast regression; covers all key paths including loading states and delete-then-update flow.
ui/litellm-dashboard/src/components/view_logs/index.tsx	Removes gear button, SpendLogsSettingsModal, and onOpenSettings prop chain; cleans up associated state and imports.
ui/litellm-dashboard/src/components/view_logs/SpendLogsSettingsModal/SpendLogsSettingsModal.tsx	Deleted — replaced by LoggingSettings under Admin Settings; functionality preserved with improved save flow.
ui/litellm-dashboard/src/components/AdminPanel.tsx	Adds a new Logging Settings tab to the Admin Settings panel, correctly placed after UISettings.
ui/litellm-dashboard/src/components/view_logs/ConfigInfoMessage.tsx	Drops onOpenSettings prop; replaces the actionable button with a static reference to Admin Settings → Logging Settings.
ui/litellm-dashboard/src/app/(dashboard)/hooks/proxyConfig/useProxyConfig.test.ts	Adds test verifying useDeleteProxyConfigField calls invalidateQueries on success; exports proxyConfigKeys for the assertion.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User clicks Save] --> B{retentionPeriod filled?}
    B -- Yes --> C[mutate updateParams with retention]
    B -- No --> D[deleteField retention period]
    D -- onSuccess --> E[invalidateQueries proxyConfigKeys.all]
    D -- onError --> F[console.warn, skip and continue]
    D -- onSettled --> G[mutate updateParams no retention]
    C -- onSuccess --> H[NotificationsManager.success]
    G -- onSuccess --> H
    C -- onError --> I[NotificationsManager.fromBackend]
    G -- onError --> I
    H --> J[invalidateQueries proxyConfigKeys.all]
    J --> K[useProxyConfig refetches, proxyConfigData updates]
    K --> L[initialValues recomputes, Form key changes]
    L --> M[Form resets to server values]

Loading

_{Reviews (5): Last reviewed commit: "test(ui): reset mocks between LoggingSet..." | Re-trigger Greptile}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!