Skip to content

fix: increase health check max_tokens default to 16 (#23836) #26610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sameerlite merged 2 commits into from
Jun 18, 2026
Merged

fix: increase health check max_tokens default to 16 (#23836) #26610

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd3eadb
fix: increase health check max_tokens from 5 to 16 (#23836)
hannahmadison Apr 27, 2026
3ae8ca3
Merge branch 'litellm_oss_staging' into fix/health-check-max-tokens-2…
Sameerlite Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions litellm/proxy/health_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ def _resolve_health_check_max_tokens(
3. For non-wildcard reasoning routes: BACKGROUND_HEALTH_CHECK_MAX_TOKENS_REASONING
from env (if set)
4. BACKGROUND_HEALTH_CHECK_MAX_TOKENS (global, any route including wildcards)
5. Non-wildcard default: 5
5. Non-wildcard default: 16
6. Wildcard and nothing from (1)(4): leave unset (caller omits max_tokens)
"""
explicit = model_info.get("health_check_max_tokens", None)
Expand Down Expand Up @@ -350,7 +350,7 @@ def _resolve_health_check_max_tokens(
return int(BACKGROUND_HEALTH_CHECK_MAX_TOKENS)

if not is_wildcard:
return 5
return 16

return None

Expand Down
13 changes: 6 additions & 7 deletions tests/test_litellm/proxy/test_health_check_max_tokens.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
@pytest.mark.asyncio
async def test_update_litellm_params_max_tokens_default(monkeypatch):
"""
Test that max_tokens defaults to 5 for non-wildcard models.
Test that max_tokens defaults to 16 for non-wildcard models.
"""
monkeypatch.setattr(hc_module, "BACKGROUND_HEALTH_CHECK_MAX_TOKENS", None)
monkeypatch.setattr(hc_module, "BACKGROUND_HEALTH_CHECK_MAX_TOKENS_REASONING", None)
Expand All @@ -22,7 +22,7 @@ async def test_update_litellm_params_max_tokens_default(monkeypatch):

updated_params = _update_litellm_params_for_health_check(model_info, litellm_params)

assert updated_params["max_tokens"] == 5
assert updated_params["max_tokens"] == 16


@pytest.mark.asyncio
Expand All @@ -48,8 +48,7 @@ async def test_update_litellm_params_max_tokens_wildcard():

updated_params = _update_litellm_params_for_health_check(model_info, litellm_params)

# Should not be set to 1
assert "max_tokens" not in updated_params or updated_params["max_tokens"] != 1
assert "max_tokens" not in updated_params


@pytest.mark.asyncio
Expand Down Expand Up @@ -160,14 +159,14 @@ def test_explicit_health_check_max_tokens_beats_reasoning_specific():


def test_reasoning_specific_falls_through_when_wrong_branch_only(monkeypatch):
"""Only non-reasoning key set but model is reasoning → fall back to default 5."""
"""Only non-reasoning key set but model is reasoning → fall back to default 16."""
monkeypatch.setattr(hc_module, "BACKGROUND_HEALTH_CHECK_MAX_TOKENS", None)
monkeypatch.setattr(hc_module, "BACKGROUND_HEALTH_CHECK_MAX_TOKENS_REASONING", None)
model_info = {"health_check_max_tokens_non_reasoning": 3}
litellm_params = {"model": "openai/o1"}

with patch.object(hc_module.litellm, "supports_reasoning", return_value=True):
assert _resolve_health_check_max_tokens(model_info, litellm_params) == 5
assert _resolve_health_check_max_tokens(model_info, litellm_params) == 16


@pytest.mark.asyncio
Expand All @@ -180,7 +179,7 @@ async def test_background_split_env_reasoning_vs_non_reasoning(monkeypatch):

with patch.object(hc_module.litellm, "supports_reasoning", return_value=False):
updated = _update_litellm_params_for_health_check(model_info, litellm_params)
assert updated["max_tokens"] == 5
assert updated["max_tokens"] == 16

litellm_params2 = {"model": "openai/o1"}
with patch.object(hc_module.litellm, "supports_reasoning", return_value=True):
Expand Down
Loading