fix(ovhcloud): Fix tool calling not working - #25948
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@greptileai Please make a review |
Greptile SummaryThis PR removes the Confidence Score: 5/5Safe to merge — targeted removal of a stale static filter with a clear unit test verifying the new behavior. All findings are P2 or lower. The core change is a clean deletion of over-eager param filtering; the inherited behavior from OpenAIGPTConfig is well-understood and correct. The new test exercises the exact code path that was broken. No security, data-integrity, or reliability concerns. No files require special attention.
|
| Filename | Overview |
|---|---|
| litellm/llms/ovhcloud/chat/transformation.py | Removes the get_supported_openai_params override that conditionally stripped tool-calling params based on a stale static catalog; now inherits the full OpenAI param list from OpenAIGPTConfig. |
| tests/test_litellm/llms/ovhcloud/test_ovhcloud_chat_transformation.py | Adds test_tools_not_filtered_by_static_model_map (pure unit test, no network calls) covering 5 model names; remaining changes are Black-style formatting fixes. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[LiteLLM call with tools param] --> B{OVHCloudChatConfig\nget_supported_openai_params}
subgraph BEFORE["BEFORE (removed)"]
B1[Call _get_model_info_helper] --> B2{supports_function_calling?}
B2 -->|True| B3[Include tools, tool_choice,\nfunction_call, response_format]
B2 -->|False / error| B4[Strip tools, tool_choice,\nfunction_call, response_format]
end
subgraph AFTER["AFTER (this PR)"]
C[Inherit OpenAIGPTConfig list:\nalways includes tools, tool_choice,\nfunction_call, response_format]
end
B --> BEFORE
B --> AFTER
B3 --> D[OVHCloud API]
C --> D
B4 --> E[Tools silently dropped —\nrequest fails for supported models]
D --> F{Server-side validation}
F -->|Supported| G[Success]
F -->|Not supported| H[Server returns error]
Reviews (2): Last reviewed commit: "fix import order" | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bd145d1
into
BerriAI:litellm_oss_staging_04_22_2026
* fix(ovhcloud): fix tool calling * fix import order
Pre-Submission checklist
tests/test_litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unit@greptileaiand received a Confidence Score of at least 4/5 before requesting a maintainer reviewDelays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
CI (LiteLLM team)
Branch creation CI run
Link:
CI run for the last commit
Link:
Merge / cherry-pick CI run
Links:
Screenshots / Proof of Fix
Type
🐛 Bug Fix
🧹 Refactoring
✅ Test
Changes
Remove supported openai params, so only the OVHcloud returns an error if the tool calling is not supported.